Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-637] Map param ex_blockdevicemappings to block_device_mapping_v2 #398

Closed

Conversation

gertjanol
Copy link
Contributor

@gertjanol gertjanol commented Nov 21, 2014

Add support the for the block_device_mapping_v2-parameter in Compute API v2 extensions.
https://issues.apache.org/jira/browse/LIBCLOUD-637

@allardhoeve
Copy link
Contributor

allardhoeve commented Feb 12, 2015

bump

@Kami
Copy link
Member

Kami commented Feb 12, 2015

Hey, sorry for the delay, looks like we some how missed this one.

The change looks good to me, but the build failures need to be fixed.

@allardhoeve
Copy link
Contributor

allardhoeve commented Feb 12, 2015

Where do the failures stem from? I couldn't parse the log 😄 It looks like unrelated PEP8 errors?

@Kami
Copy link
Member

Kami commented Feb 12, 2015

Yep, pep8 / lint violation.

@allardhoeve
Copy link
Contributor

allardhoeve commented Feb 12, 2015

Ah, I was thrown off by the 700 or so other line too long exceptions that flake8 reports.

But fixed as requested!

@allardhoeve
Copy link
Contributor

allardhoeve commented Feb 17, 2015

bump

@asfgit asfgit closed this in 014c0c5 Feb 17, 2015
@Kami
Copy link
Member

Kami commented Feb 17, 2015

Merged into trunk. Thanks.

@allardhoeve allardhoeve deleted the 637_block_device_mapping_v2 branch Mar 6, 2015
@allardhoeve allardhoeve restored the 637_block_device_mapping_v2 branch Mar 6, 2015
@allardhoeve allardhoeve deleted the 637_block_device_mapping_v2 branch Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants