New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenStack Alpha No Longer Returning Node Data on Server Create #40

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@tildedave
Contributor

tildedave commented Nov 30, 2011

WHY THIS HAD TO BE DONE

OpenStack Alpha at http://alpha.auth.api.rackspacecloud.com:5000/v2.0/ has started conforming to the spec and not returning any node data back except for new password on node create.

See: http://docs.openstack.org/cactus/openstack-compute/developer/openstack-compute-api-1.1/content/CreateServers.html

"Note that when creating a server only the server ID, its links, and the admin password are guaranteed to be returned in the request. Additional attributes may be retrieved by performing subsequent GETs on the server."

Specifically the OpenStack 1.1 node driver was failing on create_node as it was attempting to fill the information to create a libcloud node from the server response (which is not just returning ID and admin password).

WHAT

The implementation I took here was to do the follow-up GET to get the node information. There is enough information returned there to make a libcloud node object, though some of it won't be filled in until the server has gone from BUILD to ACTIVE (for example, ip addresses).

I changed some of the create_node test data to match the existing asserts.

Update test data to include new create response. Do a follow-up GET a…
…fter creating a node to get all of the necessary information (name, status, ip addresses, metadata)
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 30, 2011

Member

Yeah, that's an acceptable solution. We do a similar thing in some other drivers.

Merged in r1208595 - http://svn.apache.org/viewvc?view=revision&revision=1208595.

Member

Kami commented Nov 30, 2011

Yeah, that's an acceptable solution. We do a similar thing in some other drivers.

Merged in r1208595 - http://svn.apache.org/viewvc?view=revision&revision=1208595.

@tildedave

This comment has been minimized.

Show comment
Hide comment
@tildedave

tildedave Nov 30, 2011

Contributor

Thanks Kami!

Contributor

tildedave commented Nov 30, 2011

Thanks Kami!

@tildedave tildedave closed this Nov 30, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment