[google compute] allow use of GCEDiskType in existing methods#428
Closed
erjohnso wants to merge 1 commit intoapache:trunkfrom
erjohnso:GCE_DiskTypes_part2
Closed
[google compute] allow use of GCEDiskType in existing methods#428erjohnso wants to merge 1 commit intoapache:trunkfrom erjohnso:GCE_DiskTypes_part2
erjohnso wants to merge 1 commit intoapache:trunkfrom
erjohnso:GCE_DiskTypes_part2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in #391, a new
GCEDiskTyperesource was added to the GCE driver. This is a follow-up that updates the rest of the driver to allow the use of this new libcloud object vs the initial string-only support.Tests added along with updates to the
demos/gce_demo.pyscript./cc @verb