Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[LIBCLOUD-649] Add new methods for LinodeNodeDriver #430
Unit tests included
changed the title from
Libcloud 649 basic volume management linode
[LIBCLOUD-649] Add create, list, destroy methods for LinodeNodeDriver
Jan 9, 2015
I quickly glanced over the changes and they look good to me.
I'm just wondering, if we can make "ex_create_volume" and "ex_list_volume" methods some how comply with the standard API. Looking at the Linode API docs, LinodeId argument is required so sadly this might not be possible.
In order to comply with standart libcloud API, there could be create_volume() method. There are two ways it could be done.
ex_list_volumes() could be rewritten to list_volumes() with optional ex_ params, definig node or disk_id.
Sorry for the delay.
It sounds like we should just stay with extension methods for now since none of the approaches makes it fully compliant with the base API, in fact, it might just make it more confusing to the end user (it's named as the base API, but it doesn't behave as such).