New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libcloud 652 abq 3 driver #433

Closed
wants to merge 6 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@lochiiconnectivity
Contributor

lochiiconnectivity commented Jan 11, 2015

[LIBCLOUD-652] Abiquo 2.x is no longer supported by the company, I believe all providers are running 3.x which has major changes to its API. I have updated the Abiquo compute driver.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 17, 2015

Member

@lochiiconnectivity Thanks.

If all the providers are indeed running API v3, then removing support for v2 is fine. Otherwise, we should support both versions (we do a similar thing with CloudSigma and some other drivers) - can you please verify that?

Member

Kami commented Jan 17, 2015

@lochiiconnectivity Thanks.

If all the providers are indeed running API v3, then removing support for v2 is fine. Otherwise, we should support both versions (we do a similar thing with CloudSigma and some other drivers) - can you please verify that?

@Kami

View changes

Show outdated Hide outdated libcloud/common/abiquo.py
# Most of the exceptions only have one error
raise LibcloudError(errors[0].findtext('message'))
else:
raise LibcloudError('unparseable body')

This comment has been minimized.

@Kami

Kami Jan 17, 2015

Member

Probably better to at least return raw body in the exception?

Otherwise it will be hard to debug it without using LIBCLOUD_DEBUG.

@Kami

Kami Jan 17, 2015

Member

Probably better to at least return raw body in the exception?

Otherwise it will be hard to debug it without using LIBCLOUD_DEBUG.

@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/abiquo.py
# link_datacenter
self.connection.cache['locations'][loc] = get_href(e_vdc, 'edit')
loc = get_href(e_vdc, 'location')
if (loc is not None):

This comment has been minimized.

@Kami

Kami Jan 17, 2015

Member

Minor style thing - parenthesis are unnecessary.

@Kami

Kami Jan 17, 2015

Member

Minor style thing - parenthesis are unnecessary.

Fix two minor points:
1. style issue in (libcloud/compute/drivers/abiquo.py)
2. return whole body when a parse error is encountered to aid debugging (libcloud/common/abiquo.py)
@lochiiconnectivity

This comment has been minimized.

Show comment
Hide comment
@lochiiconnectivity

lochiiconnectivity Jan 18, 2015

Contributor

For the last two points, I've pushed 0298c71 which should address these.
with regards to the support for Abiquo 2.x , I will obtain a covering statement from Abiquo shortly, and I'd like to point out that the driver did not support the last versions of 2.x, 2.3, 2.4 and 2.6, these made significant changes to the API making the trunk version incompatible, (for example making JSON the default media type, see note in http://wiki.abiquo.com/display/ABI26/API+Changelog+v2.6).

Contributor

lochiiconnectivity commented Jan 18, 2015

For the last two points, I've pushed 0298c71 which should address these.
with regards to the support for Abiquo 2.x , I will obtain a covering statement from Abiquo shortly, and I'd like to point out that the driver did not support the last versions of 2.x, 2.3, 2.4 and 2.6, these made significant changes to the API making the trunk version incompatible, (for example making JSON the default media type, see note in http://wiki.abiquo.com/display/ABI26/API+Changelog+v2.6).

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 18, 2015

Member

@lochiiconnectivity Yeah, I noticed that in the API v3 change log. Didn't know this back-ward incompatible change was already introduced in v2.6.

Let us know when you hear back from Abiquo.

Member

Kami commented Jan 18, 2015

@lochiiconnectivity Yeah, I noticed that in the API v3 change log. Didn't know this back-ward incompatible change was already introduced in v2.6.

Let us know when you hear back from Abiquo.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 26, 2015

Member

@lochiiconnectivity Any updates from Abiquo?

Member

Kami commented Jan 26, 2015

@lochiiconnectivity Any updates from Abiquo?

@lochiiconnectivity

This comment has been minimized.

Show comment
Hide comment
@lochiiconnectivity

lochiiconnectivity Jan 29, 2015

Contributor

Having spoken to Abiquo, they've confirmed 2.x is not officially supported and they've looked across their customer base and can't see anything that would cause an issue if this support (for 2.x) was removed.

Contributor

lochiiconnectivity commented Jan 29, 2015

Having spoken to Abiquo, they've confirmed 2.x is not officially supported and they've looked across their customer base and can't see anything that would cause an issue if this support (for 2.x) was removed.

@asfgit asfgit closed this in 9fe6643 Jan 29, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 29, 2015

Member

Thanks. Merged into trunk.

Member

Kami commented Jan 29, 2015

Thanks. Merged into trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment