fixing missing parameter exception for ex_add_access_config function#435
Closed
pmoosh wants to merge 1 commit into
Closed
fixing missing parameter exception for ex_add_access_config function#435pmoosh wants to merge 1 commit into
pmoosh wants to merge 1 commit into
Conversation
Member
|
/cc @erjohnso |
Contributor
There was a problem hiding this comment.
@pmoosh - Looks like params should only contain 'networkInterface' [https://cloud.google.com/compute/docs/reference/latest/instances/addAccessConfig]. The rest of the data goes into the body of the request (the config dict). I also don't see an explicit reference to attribute/param called accessConfig. Looks like the body should be,
{
"kind": "compute#accessConfig",
"type": string,
"name": string,
"natIP": string
}
And we don't need to set kind.
Contributor
|
Thanks for this @pmoosh! After you remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing nic parameter throws exception in gce.ex_add_access_config