Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[google compute] Add node stop/start support #442
GCE now supports node (instance) stop/start. This PR adds the two new driver methods and supporting tests to include these new features. Note that these methods only return a boolean, so the node object must be queried again to get the new status. For example,
>>> node = gce_driver.ex_get_node('foo', 'us-central1-f') >>> print node.extra['status'] u'RUNNING' >>> gce_driver.stop_node(node) >>> node = gce_driver.ex_get_node('foo', 'us-central1-f') >>> print node.extra['status'] u'TERMINATED'
Note that the correct state for a stopped node is TERMINATED.
/cc @Kami - I'd like to get this into the next release if you're OK with that.
Sorry for a late comment.
Currently both "terminated" and "stopped" states map to Libcloud "TERMINATED" state. Does GCE internally use the same value for a terminated / destroy node (node.destroy) and stopped node (ex_stop_node)?
If it doesn't, we should map "stopped" to Libcloud.STOPPED state, otherwise it's rather painful for our users - usually, actions you can perform on a server different depending if the node is destroyed or stopped (e.g. usually you can don't anything with a terminated node, but you can start a stopped node).
No worries, sorry for not waiting longer. I was anxious to get this in on the off chance you decided to cut a new release.
GCE uses "TERMINATED" when the node is stopped. On node.destroy(), the node is removed from the system and any subsequent requests to it would result in a ResourceNotFoundError. If the node exists and is 'started', it is in the RUNNING state. Since stop/start are async_requests, the user won't see any other intermediate states, but the flow works like this:
If it's running and we 'stop' it: RUNNING->STOPPING->TERMINATED
Based on that, are there any changes I should make?
Ah, OK, thanks for the clarification.
In this case it sounds like we can and should just map TERMINATED -> STOPPED. This way it's consistent and works consistently across different providers. It would also be good to add a comment to the code so people know why terminated is mapped to stopped.
A lot of Libcloud users dynamically build actions which are available for a particular node based on the node state and other information (are there any volumes / ip addresses attached, etc.). Other providers usually don't immediately delete node from a list when destroying a server, but the simply change state to TERMINATED and when a node is in this state no action can be performed on it.
Ok, here's how it stands right now for the GCE driver (lines 793-800). Note that it's been this way for a while. I did not introduce this mapping in #442.
I think what you're proposing is to change it to:
Note, that I removed STOPPED since we don't (no longer?) have that state. Does this look correct?