list images does not break in case of invalid OS image types#447
Closed
mgogoulos wants to merge 1 commit into
Closed
list images does not break in case of invalid OS image types#447mgogoulos wants to merge 1 commit into
mgogoulos wants to merge 1 commit into
Conversation
Contributor
|
Thanks @mgogoulos - this looks great. @Kami just cut 0.17.0, so I don't think it will get added to the release, but definitely will merge when travis catches up. |
Member
|
@erjohnso If you think this is a big issue, you can also vote -1 and we can cancel the vote and roll out a new release. Or we can wait and release 0.17.1 soon after 0.17.0 is out. |
Contributor
|
I think it's a great fix and hardens the driver, but I don't think we need to hold off on 0.17.0. Adding it the next release is fine. Thanks again @mgogoulos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that list_images will not break if one of the IMAGE_PROJECTS keys (OS image types) changes in future. Right now if you run list_images with an invalid project name, the connection.request_path is not restored after the exception is run, so all requests that follow will be invalid.