Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-667] - Allow filtering in AWS list_iamges #456

Conversation

@katrielt
Copy link
Contributor

katrielt commented Feb 16, 2015

@sebgoa
Copy link
Member

sebgoa commented Feb 27, 2015

Hi @katrielt can you check your patch and make sure all tests pass. It seems that the travis tests are failing, but it may not be due to your patch. thanks

@katrielt
Copy link
Contributor Author

katrielt commented Mar 1, 2015

After rebasing to trunk, lint tests passed, as well as python2.6/python2.7 (Only interpreters I have installed)

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 8, 2015

I think the failure to build is unrelated to the patch. I suggest we merge it.

@katrielt: can you try rebaseing one more time, please? There were a lot of pep8 fixes lately. Sorry about the hassle.

…-filtering-in-aws-list_iamges
@katrielt
Copy link
Contributor Author

katrielt commented Mar 8, 2015

Seems lint is failing globally now because of some dependency issues between pep8 an flake8. After some tinkering on my own system, I was able to get flake8 to run and lint passed.

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 8, 2015

@katrielt
Copy link
Contributor Author

katrielt commented Mar 8, 2015

Edit:

libcloud/.tox/lint/lib/python2.7/site-packages/flake8-2.4.0.dist-info/METADATA
libcloud/.tox/lint/lib/python2.7/site-packages/flake8-2.4.0.dist-info/metadata.json

and manually updated the pep8 requirement to >=1.5.7,<1.7

The right way is probably to update flake8

@asfgit asfgit closed this in ab629e3 Mar 10, 2015
@sebgoa
Copy link
Member

sebgoa commented Mar 10, 2015

Looks like @Kami fixed the pep8 issue, so I am merging this cc: @katrielt @allardhoeve let's keep an eye on Travis to make sure it passes. thanks for the patch

@katrielt katrielt deleted the katrielt:LIBCLOUD-667-allow-filtering-in-aws-list_iamges branch Mar 10, 2015
MatthiasWiesnerCC pushed a commit to cloudControl/libcloud that referenced this pull request Mar 17, 2015
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>

This closes apache#456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.