Skip to content

[LIBCLOUD-667] - Allow filtering in AWS list_iamges#456

Closed
katrielt wants to merge 2 commits into
apache:trunkfrom
katrielt:LIBCLOUD-667-allow-filtering-in-aws-list_iamges
Closed

[LIBCLOUD-667] - Allow filtering in AWS list_iamges#456
katrielt wants to merge 2 commits into
apache:trunkfrom
katrielt:LIBCLOUD-667-allow-filtering-in-aws-list_iamges

Conversation

@katrielt

Copy link
Copy Markdown
Contributor

@sebgoa

sebgoa commented Feb 27, 2015

Copy link
Copy Markdown
Member

Hi @katrielt can you check your patch and make sure all tests pass. It seems that the travis tests are failing, but it may not be due to your patch. thanks

@katrielt

katrielt commented Mar 1, 2015

Copy link
Copy Markdown
Contributor Author

After rebasing to trunk, lint tests passed, as well as python2.6/python2.7 (Only interpreters I have installed)

@allardhoeve

Copy link
Copy Markdown
Contributor

I think the failure to build is unrelated to the patch. I suggest we merge it.

@katrielt: can you try rebaseing one more time, please? There were a lot of pep8 fixes lately. Sorry about the hassle.

@katrielt

katrielt commented Mar 8, 2015

Copy link
Copy Markdown
Contributor Author

Seems lint is failing globally now because of some dependency issues between pep8 an flake8. After some tinkering on my own system, I was able to get flake8 to run and lint passed.

@allardhoeve

allardhoeve commented Mar 8, 2015 via email

Copy link
Copy Markdown
Contributor

@katrielt

katrielt commented Mar 8, 2015

Copy link
Copy Markdown
Contributor Author

Edit:

libcloud/.tox/lint/lib/python2.7/site-packages/flake8-2.4.0.dist-info/METADATA
libcloud/.tox/lint/lib/python2.7/site-packages/flake8-2.4.0.dist-info/metadata.json

and manually updated the pep8 requirement to >=1.5.7,<1.7

The right way is probably to update flake8

@asfgit asfgit closed this in ab629e3 Mar 10, 2015
@sebgoa

sebgoa commented Mar 10, 2015

Copy link
Copy Markdown
Member

Looks like @Kami fixed the pep8 issue, so I am merging this cc: @katrielt @allardhoeve let's keep an eye on Travis to make sure it passes. thanks for the patch

@katrielt katrielt deleted the LIBCLOUD-667-allow-filtering-in-aws-list_iamges branch March 10, 2015 09:25
MatthiasWiesnerCC pushed a commit to cloudControl/libcloud that referenced this pull request Mar 17, 2015
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>

This closes apache#456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants