Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-668] Add volumes_attached to node.extra #462

Conversation

@allardhoeve
Copy link
Contributor

allardhoeve commented Feb 17, 2015

Please add volumes_attached extra info

@allardhoeve allardhoeve force-pushed the ByteInternet:add-attached-volumes-to-node-extra branch from 6cb9ce4 to 8f73d49 Feb 19, 2015
@allardhoeve allardhoeve force-pushed the ByteInternet:add-attached-volumes-to-node-extra branch from 8f73d49 to 0b610a5 Feb 20, 2015
@allardhoeve
Copy link
Contributor Author

allardhoeve commented Feb 21, 2015

@Kami, I think Travis still misbehaves...

@Kami
Copy link
Member

Kami commented Feb 21, 2015

Looks like a lint issue. Did you sync up this branch with latest trunk?

@allardhoeve
Copy link
Contributor Author

allardhoeve commented Feb 21, 2015

@@ -2020,8 +2021,8 @@ def _to_node(self, api_node):
key_name=api_node.get('key_name', None),
disk_config=api_node.get('OS-DCF:diskConfig', None),
config_drive=config_drive,
availability_zone=api_node.get('OS-EXT-AZ:availability_zone',
None),

This comment has been minimized.

@Kami

Kami Feb 21, 2015 Member

Next time please this as it was - we prefer to go with "explicit over implicit" and always include default value when using dict.get.

@Kami
Copy link
Member

Kami commented Feb 21, 2015

Merged into trunk. Thanks.

@asfgit asfgit closed this in 26ddc9a Feb 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.