New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-668] Add volumes_attached to node.extra #462

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@allardhoeve
Contributor

allardhoeve commented Feb 17, 2015

Please add volumes_attached extra info

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 21, 2015

Contributor

@Kami, I think Travis still misbehaves...

Contributor

allardhoeve commented Feb 21, 2015

@Kami, I think Travis still misbehaves...

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 21, 2015

Member

Looks like a lint issue. Did you sync up this branch with latest trunk?

Member

Kami commented Feb 21, 2015

Looks like a lint issue. Did you sync up this branch with latest trunk?

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 21, 2015

Contributor
Contributor

allardhoeve commented Feb 21, 2015

@@ -2020,8 +2021,8 @@ def _to_node(self, api_node):
key_name=api_node.get('key_name', None),
disk_config=api_node.get('OS-DCF:diskConfig', None),
config_drive=config_drive,
availability_zone=api_node.get('OS-EXT-AZ:availability_zone',
None),

This comment has been minimized.

@Kami

Kami Feb 21, 2015

Member

Next time please this as it was - we prefer to go with "explicit over implicit" and always include default value when using dict.get.

@Kami

Kami Feb 21, 2015

Member

Next time please this as it was - we prefer to go with "explicit over implicit" and always include default value when using dict.get.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 21, 2015

Member

Merged into trunk. Thanks.

Member

Kami commented Feb 21, 2015

Merged into trunk. Thanks.

@asfgit asfgit closed this in 26ddc9a Feb 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment