[LIBCLOUD-668] Add volumes_attached to node.extra #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allardhoeve
force-pushed
the
add-attached-volumes-to-node-extra
branch
from
6cb9ce4
to
8f73d49
Compare
allardhoeve
force-pushed
the
add-attached-volumes-to-node-extra
branch
from
8f73d49
to
0b610a5
Compare
|
@Kami, I think Travis still misbehaves... |
|
Looks like a lint issue. Did you sync up this branch with latest trunk? |
|
Yes. Rebased all of them after the pep8 fix.
|
| @@ -2020,8 +2021,8 @@ def _to_node(self, api_node): | |||
| key_name=api_node.get('key_name', None), | |||
| disk_config=api_node.get('OS-DCF:diskConfig', None), | |||
| config_drive=config_drive, | |||
| availability_zone=api_node.get('OS-EXT-AZ:availability_zone', | |||
| None), | |||
There was a problem hiding this comment.
Next time please this as it was - we prefer to go with "explicit over implicit" and always include default value when using dict.get.
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please add volumes_attached extra info