[google compute] add pricing data update script#464
[google compute] add pricing data update script#464mbrukman wants to merge 1 commit intoapache:trunkfrom
Conversation
eb51181 to
9ad9cb8
Compare
|
Updated to handle difference in pricing on a per-region basis; please see the updated |
9ad9cb8 to
da0ccd1
Compare
|
Ideally, we could pull out This way we can re-use this functionality and make sure keys are always sorted in the same order and format of the file stays the same. |
|
@Kami — the My goal after committing this PR is to refactor the Thoughts? |
da0ccd1 to
39be91b
Compare
d11ad30 to
d3e54ca
Compare
|
@Kami — ping? |
|
@mbrukman That is probably a good question for @erjohnso . Also, one other thing...I jumped the gun on my previous comments...just realized the other drivers use the name of the driver + region name for the name on the pricing json if they have different prices for regions. (e.g. ec2_ap_northeast). Having the region nested in the json as you have currently should break the _get_size_price method when called for list_sizes in the driver. To get this to work, we need to change the list_sizes method and have each region be its own entry in the json file (ie google_asia or google_europe, etc.) |
d3e54ca to
82b77b3
Compare
Also used the script to update `pricing.json` with current prices on a per-region basis. Added numeric sorting to the JSON output; as a result, all other pricing is now sorted numerically, e.g., "12GB" sorts after "3GB" and "150" sorts after "20" whereas previously, it would be the opposite.
82b77b3 to
3ecb3ea
Compare
|
I've updated this PR as follows:
|
|
Thanks for this @mbrukman! Sorry for the long wait. |
Also used the script to update
pricing.jsonwith current prices./cc: @erjohnso, @Kami