New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-672] [LIBCLOUD-673] Create volume from snapshot on EC2 and OS #467

Closed
wants to merge 5 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@allardhoeve
Contributor

allardhoeve commented Feb 24, 2015

Both platforms support creating a volume from snapshots but do not implement it.

Please see individual commit messages for reasoning on why the changes are as they are.

Allard Hoeve added some commits Feb 24, 2015

Allard Hoeve
Change signature of base class (see comment)
The base driver defines a signature that is not used by any of the drivers implementing `create_volume`.

1. `gandi` does not use the snapshot parameter.
1. `gce` uses the parameter, but accepts either a string or an object or None.
1. `ibm` does not use the snapshot parameter.
1. `opennebula` does not use the snapshot parameter.
1. `profitbricks` breaks the contract entirely.

In this PR both `ec2` and `openstack` implement the signature like this. This matches `gce`, so all drivers using the snapshot functionality act like this new signature.
@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 25, 2015

Contributor

@Kami, what do you think?

Contributor

allardhoeve commented Feb 25, 2015

@Kami, what do you think?

@allardhoeve allardhoeve changed the title from Create volume from snapshot on EC2 and OS to [LIBCLOUD-672] [LIBCLOUD-673] Create volume from snapshot on EC2 and OS Feb 25, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 28, 2015

Member

Sorry for the delay, very busy with day job recently, will look into it...

Member

Kami commented Feb 28, 2015

Sorry for the delay, very busy with day job recently, will look into it...

:param snapshot: Name of snapshot from which to create the new
volume. (optional)
:type snapshot: ``str``
:param snapshot: Snapshot from which to create the new

This comment has been minimized.

@Kami

Kami Feb 28, 2015

Member

This is a breaking change - can you please document it in docs/upgrade_notes.rst?

@Kami

Kami Feb 28, 2015

Member

This is a breaking change - can you please document it in docs/upgrade_notes.rst?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 28, 2015

Member

Besides the upgrade notes entry, the change looks good to me.

Member

Kami commented Feb 28, 2015

Besides the upgrade notes entry, the change looks good to me.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 28, 2015

Contributor

I notice there have been no upgrade notes since 1.16.0? So no notes for 1.17?

Contributor

allardhoeve commented Feb 28, 2015

I notice there have been no upgrade notes since 1.16.0? So no notes for 1.17?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 28, 2015

Member

Yeah, there were no special notes for 0.17. Just add a section for "in development" now.

Member

Kami commented Feb 28, 2015

Yeah, there were no special notes for 0.17. Just add a section for "in development" now.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 1, 2015

Contributor

Will document, but this is actually not a breaking change:

The base driver defines a signature that is not used by any of the drivers implementing create_volume.

  1. gandi does not use the snapshot parameter.
  2. gce uses the parameter, but accepts either a string or an object or None, so this breaks nothing.
  3. ibm does not use the snapshot parameter.
  4. opennebula does not use the snapshot parameter.
  5. profitbricks breaks the contract entirely.

In this PR both ec2 and openstack implement the signature like this. This matches gce partly, so all drivers using the snapshot functionality implement it using this signature.

Contributor

allardhoeve commented Mar 1, 2015

Will document, but this is actually not a breaking change:

The base driver defines a signature that is not used by any of the drivers implementing create_volume.

  1. gandi does not use the snapshot parameter.
  2. gce uses the parameter, but accepts either a string or an object or None, so this breaks nothing.
  3. ibm does not use the snapshot parameter.
  4. opennebula does not use the snapshot parameter.
  5. profitbricks breaks the contract entirely.

In this PR both ec2 and openstack implement the signature like this. This matches gce partly, so all drivers using the snapshot functionality implement it using this signature.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 1, 2015

Contributor

Documented.

Contributor

allardhoeve commented Mar 1, 2015

Documented.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 3, 2015

Contributor

@Kami, done

Contributor

allardhoeve commented Mar 3, 2015

@Kami, done

@asfgit asfgit closed this in 659d64c Mar 4, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Mar 4, 2015

Member

Merged, thanks.

Member

Kami commented Mar 4, 2015

Merged, thanks.

MatthiasWiesnerCC pushed a commit to cloudControl/libcloud that referenced this pull request Mar 17, 2015

Document create volume from snapshot changes
Closes #467

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment