Route53 creating/updating records fixes#469
Closed
vanclevstik wants to merge 2 commits intoapache:trunkfrom
Closed
Route53 creating/updating records fixes#469vanclevstik wants to merge 2 commits intoapache:trunkfrom
vanclevstik wants to merge 2 commits intoapache:trunkfrom
Conversation
Contributor
vanclevstik
commented
Feb 26, 2015
vanclevstik
commented
- Before it was not possible to set an A record that points directly to domain zone name. Fixed it with correctly parsing empty name.
- MX records priority was not handled correctly.
Member
There was a problem hiding this comment.
This is slightly confused / hard to read - would be easier if we used an actual if - I will make this change when merging the PR.
Contributor
Author
There was a problem hiding this comment.
Cool! Yeah I agree usual if makes it a bit more explicit.
asfgit
pushed a commit
that referenced
this pull request
Feb 28, 2015
Closes #469 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Member
|
Made the change (55ebfd1) and merged code into trunk. Thanks. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.