New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 creating/updating records fixes #469

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@vanclevstik
Contributor

vanclevstik commented Feb 26, 2015

  • Before it was not possible to set an A record that points directly to domain zone name. Fixed it with correctly parsing empty name.
  • MX records priority was not handled correctly.
@@ -315,7 +315,7 @@ def _update_multi_value_record(self, record, name=None, type=None,
rrs = ET.SubElement(change, 'ResourceRecordSet')
ET.SubElement(rrs, 'Name').text = record.name + '.' + \
record.zone.domain
record.zone.domain if record.name else record.zone.domain

This comment has been minimized.

@Kami

Kami Feb 28, 2015

Member

This is slightly confused / hard to read - would be easier if we used an actual if - I will make this change when merging the PR.

@Kami

Kami Feb 28, 2015

Member

This is slightly confused / hard to read - would be easier if we used an actual if - I will make this change when merging the PR.

This comment has been minimized.

@vanclevstik

vanclevstik Mar 1, 2015

Contributor

Cool! Yeah I agree usual if makes it a bit more explicit.

@vanclevstik

vanclevstik Mar 1, 2015

Contributor

Cool! Yeah I agree usual if makes it a bit more explicit.

@asfgit asfgit closed this in 22df988 Feb 28, 2015

asfgit pushed a commit that referenced this pull request Feb 28, 2015

Correctly set MX records priority for Route53
Closes #469

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 28, 2015

Member

Made the change (55ebfd1) and merged code into trunk. Thanks.

Member

Kami commented Feb 28, 2015

Made the change (55ebfd1) and merged code into trunk. Thanks.

@vanclevstik

This comment has been minimized.

Show comment
Hide comment
@vanclevstik

vanclevstik Mar 1, 2015

Contributor

Thanks!

Contributor

vanclevstik commented Mar 1, 2015

Thanks!

@dz0ny dz0ny deleted the niteoweb:route53_fixes branch Aug 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment