Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 creating/updating records fixes #469

Closed
wants to merge 2 commits into from

Conversation

vanclevstik
Copy link
Contributor

  • Before it was not possible to set an A record that points directly to domain zone name. Fixed it with correctly parsing empty name.
  • MX records priority was not handled correctly.

@@ -315,7 +315,7 @@ def _update_multi_value_record(self, record, name=None, type=None,

rrs = ET.SubElement(change, 'ResourceRecordSet')
ET.SubElement(rrs, 'Name').text = record.name + '.' + \
record.zone.domain
record.zone.domain if record.name else record.zone.domain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly confused / hard to read - would be easier if we used an actual if - I will make this change when merging the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Yeah I agree usual if makes it a bit more explicit.

@asfgit asfgit closed this in 22df988 Feb 28, 2015
asfgit pushed a commit that referenced this pull request Feb 28, 2015
Closes #469

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
@Kami
Copy link
Member

Kami commented Feb 28, 2015

Made the change (55ebfd1) and merged code into trunk. Thanks.

@vanclevstik
Copy link
Contributor Author

Thanks!

@dz0ny dz0ny deleted the route53_fixes branch August 18, 2015 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants