[LIBCLOUD-670] Improvements to HostVirtual driver #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshbhoopathy
commented
Mar 2, 2015
dineshbhoopathy
commented
- methods to handle 'Packages' concept [basically, it is a reserved compute instance with pre-allocated resources (RAM,Disk,IPs etc) in any specified location]
- changed create_node to use the extra packages method
- fix website url in docs
- fix method ordering
- fix kwargs abuse in create_node
- fix docstrings
- add test cases for extra methods
- fix the fixtures
- fix default location
added 4 commits
March 2, 2015 15:25
dineshbhoopathy
force-pushed
the
670_extra_packages
branch
from
055b739
to
565baf4
Compare
| @@ -100,7 +100,7 @@ Provider list volumes create volume destroy volume | |||
| .. _`Gandi`: http://www.gandi.net/ | |||
There was a problem hiding this comment.
Just FYI - those files are generated automatically using ./contrib/generate_provider_feature_matrix_table.py.
|
Changes look good to me. I went ahead, squashed the commits and merged them into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.