Add state attribute to StorageVolume#476
Conversation
|
EC2 Volume states: |
|
Fixed unknown node states, thanks @gertjanol |
|
@Kami, does this need a proposal @ dev? |
libcloud/compute/drivers/ec2.py
Outdated
There was a problem hiding this comment.
Minor style thing - doing self.VOLUME_STATE_MAP.get(raw_state, StorageVolumeState.UNKNOWN) saves a couple of lines of code. On top of that, code also won't break and require an immediate update if a provider adds a new state (unlikely, but still).
|
Need to update the changelog. Besides that, LGTM, +1 |
|
thanks! |
|
Documented the changelog. Will wait for the build, then merge. |
|
Looks like the build is stuck :/ |
|
Travis is very, very slow lately |
|
Yeah, build just seems to be stuck. Probably best to just merge since since we don't have admin permissions and we can't restart the build (we could push a "dummy" commit but that's annoying...). |
- Document create_volume_snapshot arguments properly - Document destroy_volume_snapshot arguments properly - Update signature to match all existing implementations - name should be optional closes apache#478
528556e to
7845e08
Compare
extra. This key varies between drivers. Also, the value varies between drivers.Nodestate is unified inNodeState.Some caveats:
UNKNOWN.UPDATE: GCE list is here: https://cloud.google.com/compute/docs/reference/latest/disks#resource