Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshotid to ec2 and os volumes extra #479

Merged

Conversation

allardhoeve
Copy link
Contributor

Add snapshot_id to extra dicts for StorageVolumes on EC2 and OpenStack.

@sebgoa
Copy link
Member

sebgoa commented Mar 10, 2015

@allardhoeve you should be able to merge this ? you got your committer bit, correct ?

@allardhoeve
Copy link
Contributor Author

I thought it well to continue to pass my commits through community review, but yes, I could commit it.

@@ -15,6 +15,11 @@ General
Compute
~~~~~~~

- StorageVolume objects now have a key called snapshot_id in their extra
dicts containing the snapshot ID the volume was based on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add that this is for ec2 and openstack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@allardhoeve allardhoeve force-pushed the add-snapshotid-to-ec2-and-os-volumes-extra branch from 48a7494 to cf04e6c Compare Mar 11, 2015
@allardhoeve allardhoeve force-pushed the add-snapshotid-to-ec2-and-os-volumes-extra branch from cf04e6c to e90e759 Compare Mar 11, 2015
@asfgit asfgit merged commit e90e759 into apache:trunk Mar 11, 2015
@allardhoeve allardhoeve deleted the add-snapshotid-to-ec2-and-os-volumes-extra branch Mar 11, 2015
MatthiasWiesnerCC pushed a commit to cloudControl/libcloud that referenced this pull request Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants