Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshotid to ec2 and os volumes extra #479

Merged

Conversation

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 6, 2015

Add snapshot_id to extra dicts for StorageVolumes on EC2 and OpenStack.

@sebgoa
Copy link
Member

sebgoa commented Mar 10, 2015

@allardhoeve you should be able to merge this ? you got your committer bit, correct ?

@allardhoeve
Copy link
Contributor Author

allardhoeve commented Mar 10, 2015

I thought it well to continue to pass my commits through community review, but yes, I could commit it.

CHANGES.rst Outdated
@@ -15,6 +15,11 @@ General
Compute
~~~~~~~

- StorageVolume objects now have a key called snapshot_id in their extra
dicts containing the snapshot ID the volume was based on.

This comment has been minimized.

@sebgoa

sebgoa Mar 10, 2015 Member

Add that this is for ec2 and openstack

This comment has been minimized.

@allardhoeve

allardhoeve Mar 10, 2015 Author Contributor

Done

@@ -31,7 +31,7 @@
"id": "cfcec3bc-b736-4db5-9535-4c24112691b5",
"metadata": {},
"size": 50,
"snapshotId": null,
"snapshotId": "01f48111-7866-4cd2-986a-e92683c4a363",
"status": "available",
"volumeType": "None"
}

This comment has been minimized.

@sebgoa

sebgoa Mar 10, 2015 Member

no need for a fixture for the ec2 testing ?

This comment has been minimized.

@allardhoeve

allardhoeve Mar 10, 2015 Author Contributor

The EC2 fixture already had snapshotId defined. I test this on line 785 of test_ec2.py.

@allardhoeve allardhoeve force-pushed the ByteInternet:add-snapshotid-to-ec2-and-os-volumes-extra branch from 48a7494 to cf04e6c Mar 11, 2015
Closes #479
@allardhoeve allardhoeve force-pushed the ByteInternet:add-snapshotid-to-ec2-and-os-volumes-extra branch from cf04e6c to e90e759 Mar 11, 2015
@asfgit asfgit merged commit e90e759 into apache:trunk Mar 11, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@allardhoeve allardhoeve deleted the ByteInternet:add-snapshotid-to-ec2-and-os-volumes-extra branch Mar 11, 2015
MatthiasWiesnerCC pushed a commit to cloudControl/libcloud that referenced this pull request Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.