Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-676: Allow describing AMI tags #482

Closed
wants to merge 1 commit into from
Closed

Conversation

@jlk
Copy link

@jlk jlk commented Mar 10, 2015

Per the referenced Jira - I can't think of a reason for why ex_describe_tags() shouldn't be able to be used for other resources besides instances and storage, so removed the filter.

John Kinsella
Removed filter that only allows returning tags for ec2 instances
@allardhoeve
Copy link
Contributor

@allardhoeve allardhoeve commented Mar 10, 2015

Yeah, that description was faulty anyway. Looks good to me.

@Kami
Copy link
Member

@Kami Kami commented Mar 17, 2015

Yeah, looks good to me as well.

I've also checked the EC2 docs and resource-type filter is indeed optional (http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeTags.html).

@asfgit asfgit closed this in f4a149e Mar 17, 2015
@Kami
Copy link
Member

@Kami Kami commented Mar 17, 2015

Fixed lint issue and merged patch into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.