Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-682] Add fields for additional OpenStack size information #488

Closed

Conversation

@jimbobhickville
Copy link
Contributor

jimbobhickville commented Mar 25, 2015

Adds:

  • swap - the amount of swap provisioned for the flavor
  • ephemeral_disk - the amount of non-root local storage for the flavor
    (from the OS-FLV-EXT-DATA extension used by Rackspace)
  • extra - additional metadata about the flavor
    (from the OS-FLV-WITH-EXT-SPECS extension used by Rackspace)
@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 25, 2015

Hey Greg!

Thanks for contributing! Can you add some unittests to the openstack tests? That way we ensure that this added value keeps working in the future. Thanks!

@jimbobhickville
Copy link
Contributor Author

jimbobhickville commented Mar 25, 2015

Oh, derp. Yes I can. I'll get the PR updated tomorrow.

Adds:
* swap - the amount of swap provisioned for the flavor
* ephemeral_disk - the amount of non-root local storage for the flavor
	(from the OS-FLV-EXT-DATA extension used by Rackspace)
* extra - additional metadata about the flavor
	(from the OS-FLV-WITH-EXT-SPECS extension used by Rackspace)
@jimbobhickville jimbobhickville force-pushed the jimbobhickville:682_add-flavor-data branch from e277785 to 1d07776 Mar 25, 2015
@jimbobhickville
Copy link
Contributor Author

jimbobhickville commented Mar 25, 2015

I added some tests similar in style to the other openstack tests around it. Let me know if they are sufficient or you'd like to see more. Looks like the sizes didn't have much test coverage other than the pricing information, so I added a few other tests in there as well.

@jimbobhickville
Copy link
Contributor Author

jimbobhickville commented Mar 26, 2015

@allardhoeve any feedback on the tests I added?

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 26, 2015

Looks good, but will wait for the tests to succeed

@jimbobhickville
Copy link
Contributor Author

jimbobhickville commented Mar 26, 2015

Is there a reason they aren't running yet? It hasn't even tried to start them it seems.

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 26, 2015

@jimbobhickville
Copy link
Contributor Author

jimbobhickville commented Mar 26, 2015

More than a day slow? Wow, ok.

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 26, 2015

Travis CI is not fast. I've seen it be a day or two. Or get stuck. In that case I'll run the tests myself.

@allardhoeve
Copy link
Contributor

allardhoeve commented Mar 27, 2015

thanks, merged

@asfgit asfgit closed this in 4261d4e Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.