New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-682] Add fields for additional OpenStack size information #488

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@jimbobhickville
Contributor

jimbobhickville commented Mar 25, 2015

Adds:

  • swap - the amount of swap provisioned for the flavor
  • ephemeral_disk - the amount of non-root local storage for the flavor
    (from the OS-FLV-EXT-DATA extension used by Rackspace)
  • extra - additional metadata about the flavor
    (from the OS-FLV-WITH-EXT-SPECS extension used by Rackspace)
@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 25, 2015

Contributor

Hey Greg!

Thanks for contributing! Can you add some unittests to the openstack tests? That way we ensure that this added value keeps working in the future. Thanks!

Contributor

allardhoeve commented Mar 25, 2015

Hey Greg!

Thanks for contributing! Can you add some unittests to the openstack tests? That way we ensure that this added value keeps working in the future. Thanks!

@jimbobhickville

This comment has been minimized.

Show comment
Hide comment
@jimbobhickville

jimbobhickville Mar 25, 2015

Contributor

Oh, derp. Yes I can. I'll get the PR updated tomorrow.

Contributor

jimbobhickville commented Mar 25, 2015

Oh, derp. Yes I can. I'll get the PR updated tomorrow.

Greg Hill
[LIBCLOUD-682] Add fields for additional OpenStack size information
Adds:
* swap - the amount of swap provisioned for the flavor
* ephemeral_disk - the amount of non-root local storage for the flavor
	(from the OS-FLV-EXT-DATA extension used by Rackspace)
* extra - additional metadata about the flavor
	(from the OS-FLV-WITH-EXT-SPECS extension used by Rackspace)
@jimbobhickville

This comment has been minimized.

Show comment
Hide comment
@jimbobhickville

jimbobhickville Mar 25, 2015

Contributor

I added some tests similar in style to the other openstack tests around it. Let me know if they are sufficient or you'd like to see more. Looks like the sizes didn't have much test coverage other than the pricing information, so I added a few other tests in there as well.

Contributor

jimbobhickville commented Mar 25, 2015

I added some tests similar in style to the other openstack tests around it. Let me know if they are sufficient or you'd like to see more. Looks like the sizes didn't have much test coverage other than the pricing information, so I added a few other tests in there as well.

@jimbobhickville

This comment has been minimized.

Show comment
Hide comment
@jimbobhickville

jimbobhickville Mar 26, 2015

Contributor

@allardhoeve any feedback on the tests I added?

Contributor

jimbobhickville commented Mar 26, 2015

@allardhoeve any feedback on the tests I added?

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 26, 2015

Contributor

Looks good, but will wait for the tests to succeed

Contributor

allardhoeve commented Mar 26, 2015

Looks good, but will wait for the tests to succeed

@jimbobhickville

This comment has been minimized.

Show comment
Hide comment
@jimbobhickville

jimbobhickville Mar 26, 2015

Contributor

Is there a reason they aren't running yet? It hasn't even tried to start them it seems.

Contributor

jimbobhickville commented Mar 26, 2015

Is there a reason they aren't running yet? It hasn't even tried to start them it seems.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 26, 2015

Contributor
Contributor

allardhoeve commented Mar 26, 2015

@jimbobhickville

This comment has been minimized.

Show comment
Hide comment
@jimbobhickville

jimbobhickville Mar 26, 2015

Contributor

More than a day slow? Wow, ok.

Contributor

jimbobhickville commented Mar 26, 2015

More than a day slow? Wow, ok.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 26, 2015

Contributor

Travis CI is not fast. I've seen it be a day or two. Or get stuck. In that case I'll run the tests myself.

Contributor

allardhoeve commented Mar 26, 2015

Travis CI is not fast. I've seen it be a day or two. Or get stuck. In that case I'll run the tests myself.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Mar 27, 2015

Contributor

thanks, merged

Contributor

allardhoeve commented Mar 27, 2015

thanks, merged

@asfgit asfgit closed this in 4261d4e Mar 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment