[LIBCLOUD-682] Add fields for additional OpenStack size information#488
[LIBCLOUD-682] Add fields for additional OpenStack size information#488jimbobhickville wants to merge 1 commit into
Conversation
|
Hey Greg! Thanks for contributing! Can you add some unittests to the openstack tests? That way we ensure that this added value keeps working in the future. Thanks! |
|
Oh, derp. Yes I can. I'll get the PR updated tomorrow. |
Adds: * swap - the amount of swap provisioned for the flavor * ephemeral_disk - the amount of non-root local storage for the flavor (from the OS-FLV-EXT-DATA extension used by Rackspace) * extra - additional metadata about the flavor (from the OS-FLV-WITH-EXT-SPECS extension used by Rackspace)
jimbobhickville
force-pushed
the
682_add-flavor-data
branch
from
e277785 to
1d07776
Compare
|
I added some tests similar in style to the other openstack tests around it. Let me know if they are sufficient or you'd like to see more. Looks like the sizes didn't have much test coverage other than the pricing information, so I added a few other tests in there as well. |
|
@allardhoeve any feedback on the tests I added? |
|
Looks good, but will wait for the tests to succeed |
|
Is there a reason they aren't running yet? It hasn't even tried to start them it seems. |
|
Travis is slooooww
|
|
More than a day slow? Wow, ok. |
|
Travis CI is not fast. I've seen it be a day or two. Or get stuck. In that case I'll run the tests myself. |
|
thanks, merged |
2 participants
Adds:
(from the OS-FLV-EXT-DATA extension used by Rackspace)
(from the OS-FLV-WITH-EXT-SPECS extension used by Rackspace)