New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-686] Address validation fails with CPython 2.7.9 on Windows. #498

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@SamuelMarks
Contributor

SamuelMarks commented Apr 3, 2015

No description provided.

@SamuelMarks

This comment has been minimized.

Show comment
Hide comment
@SamuelMarks

SamuelMarks Apr 3, 2015

Contributor

I'm uncertain if my use of check on force_ipv4 is valid. When IPv4 isn't forced, that doesn't mean it's not allowed; right?

Contributor

SamuelMarks commented Apr 3, 2015

I'm uncertain if my use of check on force_ipv4 is valid. When IPv4 isn't forced, that doesn't mean it's not allowed; right?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Apr 4, 2015

Member

Thanks for the PR.

There is already a similar PR which tries to address that - #343. We should figure out how to consolidate those two and get it merged.

I personally think approach in #343 is better start since it handles this difference in the function where this problem can arise.

What do you think?

Member

Kami commented Apr 4, 2015

Thanks for the PR.

There is already a similar PR which tries to address that - #343. We should figure out how to consolidate those two and get it merged.

I personally think approach in #343 is better start since it handles this difference in the function where this problem can arise.

What do you think?

bassdread pushed a commit to serverdensity/libcloud that referenced this pull request Apr 10, 2015

Add new Honolulu, HI endpoint to the CloudSigma driver.
Closes #498

Signed-off-by: Tomaz Muraus <tomaz@apache.org>

@asfgit asfgit closed this in 918cb0f Jun 20, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 20, 2015

Member

Sorry for the delay. I've added a check for validating IPv6 address on Windows (e105433) and merged changes into trunk.

Thanks.

Member

Kami commented Jun 20, 2015

Sorry for the delay. I've added a check for validating IPv6 address on Windows (e105433) and merged changes into trunk.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment