Skip to content

[LIBCLOUD-686] Address validation fails with CPython 2.7.9 on Windows.#498

Closed
SamuelMarks wants to merge 1 commit intoapache:trunkfrom
SamuelMarks:trunk
Closed

[LIBCLOUD-686] Address validation fails with CPython 2.7.9 on Windows.#498
SamuelMarks wants to merge 1 commit intoapache:trunkfrom
SamuelMarks:trunk

Conversation

@SamuelMarks
Copy link
Copy Markdown
Contributor

No description provided.

@SamuelMarks
Copy link
Copy Markdown
Contributor Author

I'm uncertain if my use of check on force_ipv4 is valid. When IPv4 isn't forced, that doesn't mean it's not allowed; right?

@Kami
Copy link
Copy Markdown
Member

Kami commented Apr 4, 2015

Thanks for the PR.

There is already a similar PR which tries to address that - #343. We should figure out how to consolidate those two and get it merged.

I personally think approach in #343 is better start since it handles this difference in the function where this problem can arise.

What do you think?

@asfgit asfgit closed this in 918cb0f Jun 20, 2015
@Kami
Copy link
Copy Markdown
Member

Kami commented Jun 20, 2015

Sorry for the delay. I've added a check for validating IPv6 address on Windows (e105433) and merged changes into trunk.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants