LIBCLOUD-698 rename OpSource Dimension Data. Added Dimension Data driver... #507
Conversation
…ing, PEP8 compliance completed.
|
Sorry for the delay and thanks. Would it be possible for us to get a test account so we can test out the changes on a real installation? |
|
Overall, after quickly glancing over it, the changes look good. Can you please add some documentation to |
| step_number=None, step_percentComplete=None, | ||
| failureReason=None): | ||
| self.action = action | ||
| self.requestTime = requestTime |
There was a problem hiding this comment.
Heh, looks like this stylistic thing slipped through when we originally reviewed and merged opsource driver.
Variables should use underscore separated names and not camel case. It seems that now that we are adding a new driver is a good time to fix that.
…ver, replaced kwargs with named parameters as per libcloud BP.
|
Commit added to pull request with changes on casing, docstrings and kwargs refactoring. Will work on the documentation side now. |
|
Documentation edits have been contributed back to the branch. Please let me know if we can move ahead. |
| type = Provider.DIMENSIONDATA | ||
| features = {'create_node': ['password']} | ||
|
|
||
| def create_node(self, name, image, auth, ex_description, |
|
@tonybaloney Thanks, changes look good. Can you please squash the commits and I will go ahead and merge it into trunk. |
…ver. LIBCLOUD-698 Added provider type for dimension data LIBCLOUD-698 Added missing text fixtures and test parameters LIBCLOUD-698 Reformatted lines as "DimensionData" is quite a long string, PEP8 compliance completed. LIBCLOUD-698 worked through casing changes from original opsource driver, replaced kwargs with named parameters as per libcloud BP. LIBCLOUD-698 Added some documentation of the driver LIBCLOUD-698 Added indexes and support matrix for the driver
…ttps://github.com/DimensionDataCBUSydney/libcloud into LIBCLOUD-698-rename_opsource_driver_dimension_data
|
This is the squashed commit. |
|
Patch diff file attached to jira ticket: https://issues.apache.org/jira/browse/LIBCLOUD-698 |
| @@ -9,7 +9,8 @@ Provider list volumes create volume destroy volume | |||
| `CloudFrames`_ no no no no no no no | |||
There was a problem hiding this comment.
Just for the future reference - those documents are updated automatically using ./contrib/generate_provider_feature_matrix_table.py script.
|
Merged into trunk. Thanks. |
As per LIBCLOUD-698, OpSource is now Dimension Data.
Added an additional driver (complete copy).