New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-698 rename OpSource Dimension Data. Added Dimension Data driver... #507

Closed
wants to merge 10 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@tonybaloney
Contributor

tonybaloney commented Apr 21, 2015

As per LIBCLOUD-698, OpSource is now Dimension Data.
Added an additional driver (complete copy).

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 3, 2015

Member

Sorry for the delay and thanks. Would it be possible for us to get a test account so we can test out the changes on a real installation?

Member

Kami commented May 3, 2015

Sorry for the delay and thanks. Would it be possible for us to get a test account so we can test out the changes on a real installation?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 3, 2015

Member

Overall, after quickly glancing over it, the changes look good.

Can you please add some documentation to docs/compute/drivers/ (see existing driver / provider documentation for an example)?

Member

Kami commented May 3, 2015

Overall, after quickly glancing over it, the changes look good.

Can you please add some documentation to docs/compute/drivers/ (see existing driver / provider documentation for an example)?

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
step_number=None, step_percentComplete=None,
failureReason=None):
self.action = action
self.requestTime = requestTime

This comment has been minimized.

@Kami

Kami May 3, 2015

Member

Heh, looks like this stylistic thing slipped through when we originally reviewed and merged opsource driver.

Variables should use underscore separated names and not camel case. It seems that now that we are adding a new driver is a good time to fix that.

@Kami

Kami May 3, 2015

Member

Heh, looks like this stylistic thing slipped through when we originally reviewed and merged opsource driver.

Variables should use underscore separated names and not camel case. It seems that now that we are adding a new driver is a good time to fix that.

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
"""
Create a new DimensionData node
:keyword name: String with a name for this new node (required)

This comment has been minimized.

@Kami

Kami May 3, 2015

Member

Can we please also fix this and explicitly declare arguments in the method signature?

https://libcloud.readthedocs.org/en/latest/development.html#don-t-abuse-kwargs

(I know you just copied over the code from opsource driver, but if we are adding a new driver, let's fix what we can and improve it).

@Kami

Kami May 3, 2015

Member

Can we please also fix this and explicitly declare arguments in the method signature?

https://libcloud.readthedocs.org/en/latest/development.html#don-t-abuse-kwargs

(I know you just copied over the code from opsource driver, but if we are adding a new driver, let's fix what we can and improve it).

LIBCLOUD-698 worked through casing changes from original opsource dri…
…ver, replaced kwargs with named parameters as per libcloud BP.
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney May 4, 2015

Contributor

Commit added to pull request with changes on casing, docstrings and kwargs refactoring. Will work on the documentation side now.

DimensionDataCBUSydney@7faa26f

Contributor

tonybaloney commented May 4, 2015

Commit added to pull request with changes on casing, docstrings and kwargs refactoring. Will work on the documentation side now.

DimensionDataCBUSydney@7faa26f

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney May 4, 2015

Contributor

Documentation edits have been contributed back to the branch.

Please let me know if we can move ahead.

Contributor

tonybaloney commented May 4, 2015

Documentation edits have been contributed back to the branch.

Please let me know if we can move ahead.

type = Provider.DIMENSIONDATA
features = {'create_node': ['password']}
def create_node(self, name, image, auth, ex_description,

This comment has been minimized.

@Kami

Kami May 4, 2015

Member

A lot better, thanks :)

@Kami

Kami May 4, 2015

Member

A lot better, thanks :)

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 4, 2015

Member

@tonybaloney Thanks, changes look good.

Can you please squash the commits and I will go ahead and merge it into trunk.

Member

Kami commented May 4, 2015

@tonybaloney Thanks, changes look good.

Can you please squash the commits and I will go ahead and merge it into trunk.

tonybaloney added some commits Apr 21, 2015

LIBCLOUD-698 rename OpSource Dimension Data. Added Dimension Data dri…
…ver.

LIBCLOUD-698 Added provider type for dimension data

LIBCLOUD-698 Added missing text fixtures and test parameters

LIBCLOUD-698 Reformatted lines as "DimensionData" is quite a long string, PEP8 compliance completed.

LIBCLOUD-698 worked through casing changes from original opsource driver, replaced kwargs with named parameters as per libcloud BP.

LIBCLOUD-698 Added some documentation of the driver

LIBCLOUD-698 Added indexes and support matrix for the driver
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney May 4, 2015

Contributor

This is the squashed commit.
DimensionDataCBUSydney@c2b4ba6

Contributor

tonybaloney commented May 4, 2015

This is the squashed commit.
DimensionDataCBUSydney@c2b4ba6

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney May 4, 2015

Contributor

Patch diff file attached to jira ticket: https://issues.apache.org/jira/browse/LIBCLOUD-698

Contributor

tonybaloney commented May 4, 2015

Patch diff file attached to jira ticket: https://issues.apache.org/jira/browse/LIBCLOUD-698

@@ -9,7 +9,8 @@ Provider list volumes create volume destroy volume
`CloudFrames`_ no no no no no no no

This comment has been minimized.

@Kami

Kami May 6, 2015

Member

Just for the future reference - those documents are updated automatically using ./contrib/generate_provider_feature_matrix_table.py script.

@Kami

Kami May 6, 2015

Member

Just for the future reference - those documents are updated automatically using ./contrib/generate_provider_feature_matrix_table.py script.

@asfgit asfgit closed this in 119c190 May 6, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 6, 2015

Member

Merged into trunk. Thanks.

Member

Kami commented May 6, 2015

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment