Gandi Compute Driver improvement #534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZuluPro
commented
Jun 4, 2015
ZuluPro
commented
- Added sphinx documentation with example of node creation
- Added docstring for all public methods
- Added SSH keypair management: list, get, import, delete
- Change authentification initialisation in create_node: User must choose between login/password, SSH keys or both
- Added ex_get_node and ex_get_volume
- Added tests for all commit
| if kwargs.get('login') is None or kwargs.get('password') is None: | ||
| raise GandiException( | ||
| 1020, 'login and password must be defined for node creation') | ||
| if not kwargs.get('login') and not kwargs.get('keypairs'): |
There was a problem hiding this comment.
We need to fix this to use auth argument, but that's fine for now.
|
There are some minor style issues (method ordering), besides that it looks good to me. |
|
I changed For next commits, how must I raise Error for an unfound KeyPair ? Is there a hierarchy of Exceptions to use ? |
|
@ZuluPro Great. There is |
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2015
Closes #534 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2015
Closes #534 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2015
Closes #534 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2015
Closes #534 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
|
Changes merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.