Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-724] Added storage service create and delete methods to Azu… #551

Conversation

davidwilson2038
Copy link
Contributor

Added methods to create and destroy storage services in Azure and the appropriate tests. I believe this is necessary because when you use the create_node method to create a node, it will automatically create a storage service, and when you call destroy_node, it does not delete that storage service. Consequently, you must use another tool or the GUI to clean up after node creation (or to set up for it), so providing this functionality through libcloud enhances the role libcloud can play in Azure usage. Also, I think these methods belong in the compute driver rather than in the storage driver for two reasons:

  1. These are higher level functions than is accessible through the current Azure storage driver (you must specify an already-created storage service to instantiate the driver)
  2. The Azure API lumps these functions in with other compute functions, specifically separating them from object storage functions.

self._get_storage_service_path(),
AzureXmlSerializer.create_storage_service_to_xml(
service_name=name,
label=self._encode_base64(name),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, does the label really need to be base64 encoded?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my comment. I've confirmed it does indeed need to be base64 encoded - https://msdn.microsoft.com/en-us/library/azure/hh264518.aspx

@asfgit asfgit closed this in 733ea2f Aug 3, 2015
@Kami
Copy link
Member

Kami commented Aug 3, 2015

Removed docstring for tries argument which was not actually declared in the method signature and merged patch into trunk.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants