Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added volume type to create_volume in openstack #553

Closed
wants to merge 3 commits into from
Closed

Added volume type to create_volume in openstack #553

wants to merge 3 commits into from

Conversation

ricotijsen
Copy link
Contributor

@ricotijsen ricotijsen commented Jul 22, 2015

Fx. to allow to choose between SATA and SSD. When None given, the default is used.

Fx. to allow the choose between SATA and SSD
@ricotijsen ricotijsen closed this Jul 22, 2015
@ricotijsen ricotijsen reopened this Jul 22, 2015
@@ -164,7 +164,8 @@ def list_nodes(self, ex_all_tenants=False):
return self._to_nodes(
self.connection.request('/servers/detail', params=params).object)

def create_volume(self, size, name, location=None, snapshot=None):
def create_volume(self, size, name, location=None, snapshot=None,
volume_type=None):
Copy link
Member

@Kami Kami Aug 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

This is an extension argument (not part of the standard API) so it should be prefixed with ex_ - ex_volume_type.

@asfgit asfgit closed this in ebe71ac Aug 7, 2015
@Kami
Copy link
Member

Kami commented Aug 7, 2015

Made the argument name change, squashed the commits and merged changes into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants