CloudStack: fix in parsing of an empty body#555
Closed
konstan wants to merge 3 commits intoapache:trunkfrom
konstan:trunk
Closed
CloudStack: fix in parsing of an empty body#555konstan wants to merge 3 commits intoapache:trunkfrom konstan:trunk
konstan wants to merge 3 commits intoapache:trunkfrom
konstan:trunk
Conversation
if it wasn't given by the provider.
Member
|
Thanks, the change looks good, but can you please also add a test case for it? |
Member
|
@konstan bump^^ |
Member
|
I'm working on a 0.18.0 release so I merged patch into trunk. Please make sure to submit a new PR with the corresponding tests when you have a chance. Thanks. |
Contributor
Author
|
Oops... Sorry for not replying promptly (vacations time). Yes, sure - next time with a test! Thanks for the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue when
AttributeError: 'str' object has no attribute 'values'gets thrown in case of an empty body is retuned by the provider.Exception after the change: