Skip to content

Fix a bug in consuming streams in Paramiko ssh client #558

Closed
lakshmi-kannan wants to merge 2 commits intoapache:trunkfrom
lakshmi-kannan:paramiko_ssh_client_consume_streams_bug_fix
Closed

Fix a bug in consuming streams in Paramiko ssh client #558
lakshmi-kannan wants to merge 2 commits intoapache:trunkfrom
lakshmi-kannan:paramiko_ssh_client_consume_streams_bug_fix

Conversation

@lakshmi-kannan
Copy link
Copy Markdown
Contributor

@lakshmi-kannan lakshmi-kannan commented Aug 2, 2015

I wrote a wrapper to that wraps the SSH client to test. See lakshmi-kannan/st2#2 and specifically lakshmi-kannan/st2@1f0e025.

(virtualenv)/m/s/s/st2 git:paramiko_parallel_ssh ❯❯❯ st2common/bin/paramiko_ssh_evenlets_tester.py --hosts=localhost,127.0.0.1 --user=lakshmi --private-key="/home/vagrant/.ssh/id_rsa" --cmd="pwd"
"cmd results: \n{'127.0.0.1': [u'/home/lakshmi\\n', '', 0, True], 'localhost': [u'/home/lakshmi\\n', '', 0, True]}"
(virtualenv)/m/s/s/st2 git:paramiko_parallel_ssh ❯❯❯

Lakshmi Kannan added 2 commits August 2, 2015 14:54
Consume stdout, stderr streams on exit_status_ready
e5e71e1 
* In some cases such as executing commands on localhost
via SSH, exit_status_ready gets set super fast. We don't
seem to consume them if this happens. The problem
manifest when you wrap the ParamikoSSHClient inside
something like an evenlet pool. This PR fixes that issue.
Update CHANGES.rst
5462886
@asfgit asfgit closed this in c90d63d Aug 3, 2015
@Kami
Copy link
Copy Markdown
Member

Kami commented Aug 3, 2015

Good catch. Merged into trunk. Thanks.

We probably never encountered this issue because we always used it with remote servers where a higher latency would mask this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lakshmi-kannan @Kami