Added Runabove volume management & fixed many little things #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, this will go into 0.18.0 is the voting thread for 0.18.0 passes :) |
|
|
||
| :return: List of node objects that the API key can access | ||
| :returns: List of node objects |
There was a problem hiding this comment.
I think it's just return (at least that's what most other code uses). It might also be that both works, but return is preferred for consistency reasons.
ZuluPro
force-pushed
the
runabove2
branch
2 times, most recently
from
6bfb591 to
272cc16
Compare
|
I've made the "create_node" changed and merged patch into trunk. Thanks! |
|
Oh! I made a
|
|
Heh, thanks and no problem (changes were already merged). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunAbove has added volume management recently to their API, I added this to libcloud with tests.
I also: