Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Runabove volume management & fixed many little things #561

Closed
wants to merge 1 commit into from

Conversation

ZuluPro
Copy link
Contributor

@ZuluPro ZuluPro commented Aug 9, 2015

RunAbove has added volume management recently to their API, I added this to libcloud with tests.

I also:

  • Added docstrings
  • Added example of volume management in docs
  • Fixed some typo and bad doc

@Kami
Copy link
Member

Kami commented Aug 9, 2015

Great, this will go into 0.18.0 is the voting thread for 0.18.0 passes :)


:return: List of node objects that the API key can access
:returns: List of node objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just return (at least that's what most other code uses). It might also be that both works, but return is preferred for consistency reasons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected!

@ZuluPro ZuluPro force-pushed the runabove2 branch 2 times, most recently from 6bfb591 to 272cc16 Compare August 15, 2015 17:34
@Kami
Copy link
Member

Kami commented Aug 15, 2015

I've made the "create_node" changed and merged patch into trunk. Thanks!

@asfgit asfgit closed this in 7bc2d29 Aug 15, 2015
@ZuluPro
Copy link
Contributor Author

ZuluPro commented Aug 15, 2015

Oh! I made a git commit --amend for less commit!

Le 15 août 2015 à 21:30, Tomaz Muraus notifications@github.com a écrit :

I've made the "create_node" changed and merged patch into trunk. Thanks!


Reply to this email directly or view it on GitHub.

@Kami
Copy link
Member

Kami commented Aug 15, 2015

Heh, thanks and no problem (changes were already merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants