[Libcloud-732] Add implementation for World Wide DNS provider #566

aleGpereira · Aug 26, 2015

Jira ticket is https://issues.apache.org/jira/browse/LIBCLOUD-732

I'm not sure if i followed the contributor guideline in the correct way. I'll expect for comments.

aleGpereira · Aug 26, 2015

I'm not sure if i followed the contributor guideline in the correct way. I'll expect for comments.

Great, thanks. I will look as soon as I can.

Kami · Aug 27, 2015

Great, thanks. I will look as soon as I can.

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/common/worldwidedns.py

+        :rtype: ``str``
+        """
+        if self._code_response(self.body):
+            codes = self.body.split('\r\n')


Using a regular expression and re.split would be safer (e.g. \r?\n) unless the body always contains carriage return (\r).

Always contains the carriage. At least the documentation says that.

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        else:
+            return self._to_zones(zones.body)
+
+    def list_records(self, zone):


If you implement iterate_records you don't need to implement list_records since it's already implemented in the base driver as list(self._iterate_records(zone)).

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        :rtype: :class:`Record`
+        """
+        zone = self.get_zone(zone_id)
+        records = self.list_records(zone)


I assume there isn't any more efficient way to retrieve a single record (e.g. filter by id or similar)?

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        :param domain: Zone domain name (e.g. example.com)
+        :type  domain: ``str``
+
+        :param raw: Mode we use to do the update using zone file or not.


This is an extension (driver specific) argument so please prefix it with ex_ (ex_raw=False) and put it at the end after extra.

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        zone = self.get_zone(zone.id)
+        return zone
+
+    def update_record(self, record, name, type, data, entry):


Same here, please prefix entry with ex_ and put it after extra.

def update_record(self, record, name, type, data, extra=None, ex_position=1): ...

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        or
+        https://www.worldwidedns.net/dns_api_protocol_new_domain_reseller.asp
+        """
+        if type == "master":


Minor style thing - please use single quotes around strings (minus docstrings).

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+from libcloud.dns.base import DNSDriver, Zone, Record
+
+
+MAX_RECORD_ENTRIES = 40


It would be good to add a comment which explains what this constant represents.

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        self.update_zone(zone, zone.domain, extra=extra)
+        return True
+
+    def view_zone(self, domain, name_server):


This is an extension method so please prefix the method name with ex_ - def ex_view_zone(self, domain, name_server):

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+        response = self.connection.request(action, params=params)
+        return response.object
+
+    def transfer_domain(self, domain, user_id):


Same here, method name needs ex_ prefix.

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/common/worldwidedns.py

+            for code in codes:
+                if code in OK_CODES:
+                    continue
+                elif code in ERROR_CODES:


An alternative which allows this method to be shorted would be to create a module level dict constant which maps code to the exception class (e.g. ERROR_CODE_TO_EXCEPTION_CLS) and using it here.

Kami · Aug 30, 2015

Kami reviewed Aug 30, 2015

View changes

Kami · Aug 30, 2015

libcloud/dns/drivers/worldwidedns.py

+            zone = self.update_zone(zone, zone.domain, ttl=ttl)
+        return zone
+
+    def create_record(self, name, zone, type, data, entry):


Same here - entry needs to be prefixed with ex_.

@aleGpereira Thanks. I've added some comments.

Overall it looks good 👍, there are just some small things which need to be addressed.

Kami · Aug 30, 2015

@aleGpereira Thanks. I've added some comments.

Overall it looks good 👍, there are just some small things which need to be addressed.

Ok, changes are pushed :).

aleGpereira · Aug 31, 2015

Ok, changes are pushed :).

Thanks. I just wanted to merge it, but I encountered an issue with a bunch of test failing:

======================================================================
ERROR: test_delete_zone_success (__main__.WorldWideDNSTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "libcloud/test/dns/test_worldwidedns.py", line 220, in test_delete_zone_success
    zone = self.driver.list_zones()[0]
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 106, in list_zones
    return self._to_zones(zones.body)
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 450, in _to_zones
    zone = self._to_zone(line)
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 466, in _to_zone
    extra = {'HOSTMASTER': soa_block[0], 'REFRESH': soa_block[1],
IndexError: list index out of range

I had a look and it looks like something weird is going on with the splitting. As mentioned above, to be one the safe side and make it more robust I think we should also use regexed when splitting so we handle both, windows and linux new lines (with and without the carriage return).

On top of that, lint is also failing but it's a minor issue - https://travis-ci.org/apache/libcloud/builds/78253070

@aleGpereira Can you please have a look and fix it? Thanks.

Kami · Sep 4, 2015

Thanks. I just wanted to merge it, but I encountered an issue with a bunch of test failing:

======================================================================
ERROR: test_delete_zone_success (__main__.WorldWideDNSTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "libcloud/test/dns/test_worldwidedns.py", line 220, in test_delete_zone_success
    zone = self.driver.list_zones()[0]
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 106, in list_zones
    return self._to_zones(zones.body)
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 450, in _to_zones
    zone = self._to_zone(line)
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 466, in _to_zone
    extra = {'HOSTMASTER': soa_block[0], 'REFRESH': soa_block[1],
IndexError: list index out of range

I had a look and it looks like something weird is going on with the splitting. As mentioned above, to be one the safe side and make it more robust I think we should also use regexed when splitting so we handle both, windows and linux new lines (with and without the carriage return).

On top of that, lint is also failing but it's a minor issue - https://travis-ci.org/apache/libcloud/builds/78253070

@aleGpereira Can you please have a look and fix it? Thanks.

Ok. I'll check for that. Thanks.

aleGpereira · Sep 4, 2015

Ok. I'll check for that. Thanks.

Ok. I've fix the problem. Sorry for that. I didn't ran with tox before. The regex is taking place now.

aleGpereira · Sep 7, 2015

Ok. I've fix the problem. Sorry for that. I didn't ran with tox before. The regex is taking place now.

@aleGpereira One thing I forgot - since those contributions are pretty big, can you please also sign an ICLA - https://www.apache.org/licenses/#clas

Kami · Sep 25, 2015

@aleGpereira One thing I forgot - since those contributions are pretty big, can you please also sign an ICLA - https://www.apache.org/licenses/#clas

Merged, thanks!

Kami · Sep 25, 2015

Merged, thanks!

@Kami ICLA is signed and filed :).

aleGpereira · Oct 7, 2015

@Kami ICLA is signed and filed :).

aleGpereira pushed a commit to aleGpereira/libcloud that referenced this pull request Aug 31, 2015

Add changes asked in pull request #566

90659a5

aleGpereira pushed a commit to aleGpereira/libcloud that referenced this pull request Sep 1, 2015

Add changes asked in pull request #566

b4962dc

[Libcloud-732] Add implementation for World Wide DNS provider

4eed2b2

asfgit merged commit 4eed2b2 into apache:trunk Sep 25, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Sep 25, 2015

Merge branch 'trunk' into LIBCLOUD-732_worldwidedns
Closes #566 Signed-off-by: Tomaz Muraus <tomaz@apache.org> Conflicts: CHANGES.rst

e136292

aleGpereira deleted the aleGpereira:LIBCLOUD-732_worldwidedns branch Oct 12, 2015

apache/libcloud

Join GitHub today

[Libcloud-732] Add implementation for World Wide DNS provider #566

Conversation

aleGpereira commented Aug 26, 2015

This comment has been minimized.

aleGpereira commented Aug 26, 2015

This comment has been minimized.

Kami commented Aug 27, 2015

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

Kami reviewed Aug 30, 2015 View changes

This comment has been minimized.

This comment has been minimized.

Kami commented Aug 30, 2015

aleGpereira pushed a commit to aleGpereira/libcloud that referenced this pull request Aug 31, 2015

This comment has been minimized.

aleGpereira commented Aug 31, 2015

aleGpereira pushed a commit to aleGpereira/libcloud that referenced this pull request Sep 1, 2015

This comment has been minimized.

Kami commented Sep 4, 2015

This comment has been minimized.

aleGpereira commented Sep 4, 2015

This comment has been minimized.

aleGpereira commented Sep 7, 2015

This comment has been minimized.

Kami commented Sep 25, 2015

Hide details View details asfgit merged commit 4eed2b2 into apache:trunk Sep 25, 2015 1 check passed

1 check passed

asfgit pushed a commit that referenced this pull request Sep 25, 2015

This comment has been minimized.

Kami commented Sep 25, 2015

This comment has been minimized.

aleGpereira commented Oct 7, 2015

aleGpereira deleted the aleGpereira:LIBCLOUD-732_worldwidedns branch Oct 12, 2015

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

Kami reviewed Aug 30, 2015

View changes

asfgit merged commit `4eed2b2` into apache:trunk Sep 25, 2015
1 check passed