[Libcloud-732] Add implementation for World Wide DNS provider #566

aleGpereira · 2015-08-26T21:49:16Z

Jira ticket is https://issues.apache.org/jira/browse/LIBCLOUD-732

aleGpereira · 2015-08-26T22:10:30Z

I'm not sure if i followed the contributor guideline in the correct way. I'll expect for comments.

Kami · 2015-08-27T14:58:59Z

Great, thanks. I will look as soon as I can.

Kami · 2015-08-30T11:43:21Z

libcloud/common/worldwidedns.py

+        :rtype: ``str``
+        """
+        if self._code_response(self.body):
+            codes = self.body.split('\r\n')


Using a regular expression and re.split would be safer (e.g. \r?\n) unless the body always contains carriage return (\r).

Always contains the carriage. At least the documentation says that.

Kami · 2015-08-30T11:45:18Z

libcloud/dns/drivers/worldwidedns.py

+        else:
+            return self._to_zones(zones.body)
+
+    def list_records(self, zone):


If you implement iterate_records you don't need to implement list_records since it's already implemented in the base driver as list(self._iterate_records(zone)).

Kami · 2015-08-30T11:45:59Z

libcloud/dns/drivers/worldwidedns.py

+        :rtype: :class:`Record`
+        """
+        zone = self.get_zone(zone_id)
+        records = self.list_records(zone)


I assume there isn't any more efficient way to retrieve a single record (e.g. filter by id or similar)?

Kami · 2015-08-30T11:47:06Z

libcloud/dns/drivers/worldwidedns.py

+        :param domain: Zone domain name (e.g. example.com)
+        :type  domain: ``str``
+
+        :param raw: Mode we use to do the update using zone file or not.


This is an extension (driver specific) argument so please prefix it with ex_ (ex_raw=False) and put it at the end after extra.

Kami · 2015-08-30T11:48:42Z

libcloud/dns/drivers/worldwidedns.py

+        zone = self.get_zone(zone.id)
+        return zone
+
+    def update_record(self, record, name, type, data, entry):


Same here, please prefix entry with ex_ and put it after extra.

def update_record(self, record, name, type, data, extra=None, ex_position=1): ...

Kami · 2015-08-30T11:50:01Z

libcloud/dns/drivers/worldwidedns.py

+        or
+        https://www.worldwidedns.net/dns_api_protocol_new_domain_reseller.asp
+        """
+        if type == "master":


Minor style thing - please use single quotes around strings (minus docstrings).

Kami · 2015-08-30T11:51:22Z

libcloud/dns/drivers/worldwidedns.py

+from libcloud.dns.base import DNSDriver, Zone, Record
+
+
+MAX_RECORD_ENTRIES = 40


It would be good to add a comment which explains what this constant represents.

Kami · 2015-08-30T11:51:59Z

libcloud/dns/drivers/worldwidedns.py

+        self.update_zone(zone, zone.domain, extra=extra)
+        return True
+
+    def view_zone(self, domain, name_server):


This is an extension method so please prefix the method name with ex_ - def ex_view_zone(self, domain, name_server):

Kami · 2015-08-30T11:52:10Z

libcloud/dns/drivers/worldwidedns.py

+        response = self.connection.request(action, params=params)
+        return response.object
+
+    def transfer_domain(self, domain, user_id):


Same here, method name needs ex_ prefix.

Kami · 2015-08-30T11:55:09Z

libcloud/common/worldwidedns.py

+            for code in codes:
+                if code in OK_CODES:
+                    continue
+                elif code in ERROR_CODES:


An alternative which allows this method to be shorted would be to create a module level dict constant which maps code to the exception class (e.g. ERROR_CODE_TO_EXCEPTION_CLS) and using it here.

Kami · 2015-08-30T11:56:27Z

libcloud/dns/drivers/worldwidedns.py

+            zone = self.update_zone(zone, zone.domain, ttl=ttl)
+        return zone
+
+    def create_record(self, name, zone, type, data, entry):


Same here - entry needs to be prefixed with ex_.

Kami · 2015-08-30T11:57:12Z

@aleGpereira Thanks. I've added some comments.

Overall it looks good 👍, there are just some small things which need to be addressed.

aleGpereira · 2015-08-31T16:52:27Z

Ok, changes are pushed :).

Kami · 2015-09-04T18:30:15Z

Thanks. I just wanted to merge it, but I encountered an issue with a bunch of test failing:

======================================================================
ERROR: test_delete_zone_success (__main__.WorldWideDNSTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "libcloud/test/dns/test_worldwidedns.py", line 220, in test_delete_zone_success
    zone = self.driver.list_zones()[0]
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 106, in list_zones
    return self._to_zones(zones.body)
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 450, in _to_zones
    zone = self._to_zone(line)
  File "/w/lc/libcloud/libcloud/dns/drivers/worldwidedns.py", line 466, in _to_zone
    extra = {'HOSTMASTER': soa_block[0], 'REFRESH': soa_block[1],
IndexError: list index out of range

I had a look and it looks like something weird is going on with the splitting. As mentioned above, to be one the safe side and make it more robust I think we should also use regexed when splitting so we handle both, windows and linux new lines (with and without the carriage return).

On top of that, lint is also failing but it's a minor issue - https://travis-ci.org/apache/libcloud/builds/78253070

@aleGpereira Can you please have a look and fix it? Thanks.

aleGpereira · 2015-09-04T18:54:13Z

Ok. I'll check for that. Thanks.

aleGpereira · 2015-09-07T21:07:01Z

Ok. I've fix the problem. Sorry for that. I didn't ran with tox before. The regex is taking place now.

Kami · 2015-09-25T12:03:47Z

@aleGpereira One thing I forgot - since those contributions are pretty big, can you please also sign an ICLA - https://www.apache.org/licenses/#clas

Closes #566 Signed-off-by: Tomaz Muraus <tomaz@apache.org> Conflicts: CHANGES.rst

Kami · 2015-09-25T12:14:11Z

Merged, thanks!

aleGpereira · 2015-10-07T00:53:22Z

@Kami ICLA is signed and filed :).

aleGpereira force-pushed the aleGpereira:LIBCLOUD-732_worldwidedns branch 2 times, most recently from f50e263 to 9a282c1 Aug 26, 2015

Kami reviewed Aug 30, 2015
View changes

libcloud/dns/drivers/worldwidedns.py Outdated

from libcloud.dns.base import DNSDriver, Zone, Record

MAX_RECORD_ENTRIES = 40

This comment has been minimized.

Sign in to view

Kami Aug 30, 2015
Member

It would be good to add a comment which explains what this constant represents.

Kami reviewed Aug 30, 2015
View changes

libcloud/dns/drivers/worldwidedns.py Outdated

response = self.connection.request(action, params=params)

return response.object

def transfer_domain(self, domain, user_id):

This comment has been minimized.

Sign in to view

Kami Aug 30, 2015
Member

Same here, method name needs ex_ prefix.

Kami reviewed Aug 30, 2015
View changes

aleGpereira pushed a commit to aleGpereira/libcloud that referenced this pull request Aug 31, 2015

Add changes asked in pull request apache#566

90659a5

aleGpereira pushed a commit to aleGpereira/libcloud that referenced this pull request Sep 1, 2015

Add changes asked in pull request apache#566

b4962dc

aleGpereira force-pushed the aleGpereira:LIBCLOUD-732_worldwidedns branch from eeaa936 to 45be41a Sep 1, 2015

aleGpereira force-pushed the aleGpereira:LIBCLOUD-732_worldwidedns branch from f99dee7 to 0a7a629 Sep 7, 2015

[Libcloud-732] Add implementation for World Wide DNS provider

Loading status checks…

4eed2b2

aleGpereira force-pushed the aleGpereira:LIBCLOUD-732_worldwidedns branch from 3f6d888 to 4eed2b2 Sep 7, 2015

asfgit merged commit 4eed2b2 into apache:trunk Sep 25, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Sep 25, 2015

Merge branch 'trunk' into LIBCLOUD-732_worldwidedns

Loading status checks…

e136292

Closes #566 Signed-off-by: Tomaz Muraus <tomaz@apache.org> Conflicts: CHANGES.rst

aleGpereira deleted the aleGpereira:LIBCLOUD-732_worldwidedns branch Oct 12, 2015

apache / libcloud

[Libcloud-732] Add implementation for World Wide DNS provider #566

[Libcloud-732] Add implementation for World Wide DNS provider #566

aleGpereira commented Aug 26, 2015

aleGpereira commented Aug 26, 2015

Kami commented Aug 27, 2015

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Kami commented Aug 30, 2015

aleGpereira commented Aug 31, 2015

Kami commented Sep 4, 2015

aleGpereira commented Sep 4, 2015

aleGpereira commented Sep 7, 2015

Kami commented Sep 25, 2015

Kami commented Sep 25, 2015

aleGpereira commented Oct 7, 2015

		from libcloud.dns.base import DNSDriver, Zone, Record


		MAX_RECORD_ENTRIES = 40

apache / libcloud

[Libcloud-732] Add implementation for World Wide DNS provider #566

[Libcloud-732] Add implementation for World Wide DNS provider #566

Conversation

aleGpereira commented Aug 26, 2015

aleGpereira commented Aug 26, 2015

Kami commented Aug 27, 2015

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

aleGpereira Aug 31, 2015 Author Contributor

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

This comment has been minimized.

Kami Aug 30, 2015 Member

Kami commented Aug 30, 2015

aleGpereira commented Aug 31, 2015

Kami commented Sep 4, 2015

aleGpereira commented Sep 4, 2015

aleGpereira commented Sep 7, 2015

Kami commented Sep 25, 2015

Kami commented Sep 25, 2015

aleGpereira commented Oct 7, 2015

Kami Aug 30, 2015
Member

aleGpereira Aug 31, 2015
Author Contributor

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member

Kami Aug 30, 2015
Member