-
Notifications
You must be signed in to change notification settings - Fork 929
[Libcloud-732] Add implementation for World Wide DNS provider #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f50e263
to
9a282c1
Compare
I'm not sure if i followed the contributor guideline in the correct way. I'll expect for comments. |
Great, thanks. I will look as soon as I can. |
:rtype: ``str`` | ||
""" | ||
if self._code_response(self.body): | ||
codes = self.body.split('\r\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a regular expression and re.split
would be safer (e.g. \r?\n
) unless the body always contains carriage return (\r).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always contains the carriage. At least the documentation says that.
@aleGpereira Thanks. I've added some comments. Overall it looks good 👍, there are just some small things which need to be addressed. |
Ok, changes are pushed :). |
eeaa936
to
45be41a
Compare
Thanks. I just wanted to merge it, but I encountered an issue with a bunch of test failing:
I had a look and it looks like something weird is going on with the splitting. As mentioned above, to be one the safe side and make it more robust I think we should also use regexed when splitting so we handle both, windows and linux new lines (with and without the carriage return). On top of that, lint is also failing but it's a minor issue - https://travis-ci.org/apache/libcloud/builds/78253070 @aleGpereira Can you please have a look and fix it? Thanks. |
Ok. I'll check for that. Thanks. |
f99dee7
to
0a7a629
Compare
3f6d888
to
4eed2b2
Compare
Ok. I've fix the problem. Sorry for that. I didn't ran with tox before. The regex is taking place now. |
@aleGpereira One thing I forgot - since those contributions are pretty big, can you please also sign an ICLA - https://www.apache.org/licenses/#clas |
Closes #566 Signed-off-by: Tomaz Muraus <tomaz@apache.org> Conflicts: CHANGES.rst
Merged, thanks! |
@Kami ICLA is signed and filed :). |
Jira ticket is https://issues.apache.org/jira/browse/LIBCLOUD-732