New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-725] Fix handling of binary data in LocalStorageDriver on Py3. #568

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@torfsen
Contributor

torfsen commented Aug 28, 2015

This PR fixes issue LIBCLOUD-725: libcloud.storage.driver.local.LocalStorageDriver has problems with binary data on Python 3.

The fix is to make sure that files are opened in binary mode for reading and writing.

Tests and documentation have been updated.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Aug 29, 2015

Member

Changes look good to made so I went ahead and merged them into trunk. Thanks!

/cc @mahendra

Member

Kami commented Aug 29, 2015

Changes look good to made so I went ahead and merged them into trunk. Thanks!

/cc @mahendra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment