GCE: Update generic auth error message #571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google authentication will fail if your time drift (difference between your local time and time on google servers) is bigger than 5 minutes. This often happens on the VM instances running in various cloud providers. Google itself doesn't provide any helpful indication of the issue, the response is just {u'error': u'invalid_grant'}.
mtekel
changed the title
|
It looks like it would also be good to document this in the docs. Besides that, LGTM. Thanks. /cc @erjohnso |
|
Hi, I am not sure what is the best place to put this information in the docs. Should that be a separate PR? |
|
Ideally, it would be the same PR. You could put it in the section where it's document how you retrieve the credentials. |
Mention that large time drift will cause authentication failures in the documentation for GCE.
|
Added doc update. Hopefully it's in the right place. |
|
Hi, have you had time to look at this? It's not a big change, but it can save some people a lot of time debugging issues... |
asfgit
pushed a commit
that referenced
this pull request
Sep 25, 2015
Mention that large time drift will cause authentication failures in the documentation for GCE. Closes #571 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google authentication will fail if your time drift (difference between your local time and time on google servers) is bigger than 5 minutes. This often happens on the VM instances running in various cloud providers. Google itself doesn't provide any helpful indication of the issue, the response is just
{u'error': u'invalid_grant'}.There is also problem in the
_get_error(self, body), line 205: the error response returned by google above will mean that err is a string, not a dictionary.err.getwill then throw attribute error, which displays generic error message. I think it is better to display the generic error message than not so helpful 'invalid_grant' response from google. You might decide to fix or change that later, but for now I think it's important to hint about time drift to the user, as this happens quite often and it's hard to find, if you only check whether your credentials are correct (which they can be, but you'll still fail auth with big time drift).