[LIBCLOUD-740] Add Point DNS provider implementation #576

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@aleGpereira
Contributor

aleGpereira commented Sep 8, 2015

No description provided.

@aleGpereira

This comment has been minimized.

Show comment
Hide comment
@aleGpereira

aleGpereira Sep 22, 2015

Contributor

I've noticed i forgot to add tests for a couple of classes. Do not merge this one yet please :)

Contributor

aleGpereira commented Sep 22, 2015

I've noticed i forgot to add tests for a couple of classes. Do not merge this one yet please :)

+ redirect = self._to_redirect(response.object, zone.id)
+ return redirect
+
+ def ex_get_mailredirects(self, zone, mail_r_id):

This comment has been minimized.

@Kami

Kami Sep 25, 2015

Member

I will make a minor change while merging this pr - mailredirects -> mail_redirects hope you don't mind :)

@Kami

Kami Sep 25, 2015

Member

I will make a minor change while merging this pr - mailredirects -> mail_redirects hope you don't mind :)

+ redirect = self._to_redirect(response.object, zone.id)
+ return redirect
+
+ def ex_create_mailredirect(self, destination, source, zone):

This comment has been minimized.

@Kami

Kami Sep 25, 2015

Member

In the future please also add test cases for all the extension methods. Thanks.

@Kami

Kami Sep 25, 2015

Member

In the future please also add test cases for all the extension methods. Thanks.

@asfgit asfgit closed this in 763dfb3 Sep 25, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Sep 25, 2015

Member

Merged, thanks!

Member

Kami commented Sep 25, 2015

Merged, thanks!

@aleGpereira aleGpereira deleted the aleGpereira:LIBCLOUD-740_pointDNS branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment