Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2 driver support for assigning a public ip #590

Closed
wants to merge 3 commits into from

Conversation

@kyle-long
Copy link
Contributor

kyle-long commented Sep 30, 2015

These changes add ex_assign_public_ip parameter to ec2 compute drivers create_node method.

The biggest thing to note (which is also in the comments) is that since the public ip takes a few seconds to get assigned, the node object returned will not have a public ip set on it. A user could always use wait_until_running in the base compute driver.

kyle-long added 3 commits Sep 30, 2015
One important thing to note is that the node returned will not
have a public_ip assigned since it takes a few seconds for amazon
to assign the public_ip (or at least for it to get returned
through the API).
@Kami
Copy link
Member

Kami commented Oct 2, 2015

Thanks. LGTM.

As discussed on the IRC - eventually we will want the same behavior in other drivers such as OpenStack and CloudStack. OpenStack + Neutron without nova networking results in a similar default behavior (no public IP by default).

@asfgit asfgit closed this in 1de64d2 Oct 2, 2015
asfgit pushed a commit that referenced this pull request Oct 2, 2015
Closes #590

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
asfgit pushed a commit that referenced this pull request Oct 2, 2015
https://tools.ietf.org/html/rfc5737

Closes #590

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
@Kami
Copy link
Member

Kami commented Oct 2, 2015

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.