ec2 driver support for assigning a public ip #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One important thing to note is that the node returned will not have a public_ip assigned since it takes a few seconds for amazon to assign the public_ip (or at least for it to get returned through the API).
|
Thanks. LGTM. As discussed on the IRC - eventually we will want the same behavior in other drivers such as OpenStack and CloudStack. OpenStack + Neutron without nova networking results in a similar default behavior (no public IP by default). |
asfgit
pushed a commit
that referenced
this pull request
Oct 2, 2015
Closes #590 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Oct 2, 2015
https://tools.ietf.org/html/rfc5737 Closes #590 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add ex_assign_public_ip parameter to ec2 compute drivers create_node method.
The biggest thing to note (which is also in the comments) is that since the public ip takes a few seconds to get assigned, the node object returned will not have a public ip set on it. A user could always use wait_until_running in the base compute driver.