New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-751] Add tests in Point DNS provider for Redirects and Mail… #591

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@aleGpereira
Contributor

aleGpereira commented Sep 30, 2015

…Redirects classes

@asfgit asfgit closed this in 58c4ec9 Oct 3, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 3, 2015

Member

I made a change to the PointDNSException class so it inherits from ProviderError which is intended to be used for that purpose - 0855665. I also updated the constructor signature so it matches the parent one.

For the future reference - this class doesn't really provide additional value over the existing ProviderError one (all the information is already available via ProviderError class) so there is little value in adding / having it.

Besides that the changes look good so I've merged it into trunk.

Thanks.

Member

Kami commented Oct 3, 2015

I made a change to the PointDNSException class so it inherits from ProviderError which is intended to be used for that purpose - 0855665. I also updated the constructor signature so it matches the parent one.

For the future reference - this class doesn't really provide additional value over the existing ProviderError one (all the information is already available via ProviderError class) so there is little value in adding / having it.

Besides that the changes look good so I've merged it into trunk.

Thanks.

except (BaseHTTPError, MalformedResponseError):
e = sys.exc_info()[1]
if isinstance(e, MalformedResponseError) and e.body == 'Not found':
raise RecordDoesNotExistError(value="Record doesn't exists",

This comment has been minimized.

@Kami

Kami Oct 3, 2015

Member

Another "for the future reference" - Ideally those exceptions would be handled on the Response class - see how other classes use set_context method.

@Kami

Kami Oct 3, 2015

Member

Another "for the future reference" - Ideally those exceptions would be handled on the Response class - see how other classes use set_context method.

@aleGpereira

This comment has been minimized.

Show comment
Hide comment
@aleGpereira

aleGpereira Oct 4, 2015

Contributor

Yeah, you're right. My intention only was to specify the provider. If for some reason someone needs to catch an exception only for pointdns, can use it. But, yeah. Is just a little thing.

Contributor

aleGpereira commented Oct 4, 2015

Yeah, you're right. My intention only was to specify the provider. If for some reason someone needs to catch an exception only for pointdns, can use it. But, yeah. Is just a little thing.

@aleGpereira

This comment has been minimized.

Show comment
Hide comment
@aleGpereira

aleGpereira Oct 4, 2015

Contributor

Thanks for the merges!

Contributor

aleGpereira commented Oct 4, 2015

Thanks for the merges!

@aleGpereira aleGpereira deleted the aleGpereira:LIBCLOUD-751_pointsdnstests branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment