LIBCLOUD-753 MCP 2 coverage dimension data #593
Conversation
Corrected dd-ap 'host'
…e) with unit tests.
… update (disable/enable), create and delete. Inc unit tests
| DimensionData Public IP Block with location. | ||
| """ | ||
|
|
||
| def __init__(self, id, baseIp, size, location, network_domain, |
There was a problem hiding this comment.
Minor thing - for consistency please use base_ip instead of baseIp.
|
Great, thanks. I've added some comments. |
|
All fixed. going to work through the doc strings next week hopefully to properly document how each method should be used |
|
Oops. broken 22 unit tests. luckily it's at 92% coverage! |
|
done and fixed |
| @@ -355,11 +472,14 @@ def __repr__(self): | |||
|
|
|||
|
|
|||
| class DimensionDataVIPNode(object): | |||
| def __init__(self, id, name, status, ip): | |||
| def __init__(self, id, name, status, ip, connection_limit='10000', | |||
There was a problem hiding this comment.
It looks like the limit values are string and not integers? Or just the default values are strings.
In any case, would be better if they were integers.
… update (disable/enable), create and delete. Inc unit tests Closes #593
|
Merged, thanks. |
| return response_code in ['IN_PROGRESS', 'OK'] | ||
|
|
||
| def ex_delete_firewall_rule(self, rule): | ||
| update_node = ET.Element('deleteFirewallrule', {'xmlns': TYPES_URN}) |
There was a problem hiding this comment.
@tonybaloney I think there is a typo, the XML element name is deleteFirewallRule
|
thanks @EfrenRey the PR is closed but I will fix these issues separately. good catch. these methods are really repetitive! |
Extended methods for additional functions available in the API.