LIBCLOUD-753 MCP 2 coverage dimension data#593
Closed
tonybaloney wants to merge 15 commits into
Closed
Conversation
Corrected dd-ap 'host'
…e) with unit tests.
… update (disable/enable), create and delete. Inc unit tests
Member
There was a problem hiding this comment.
Minor thing - for consistency please use base_ip instead of baseIp.
Member
|
Great, thanks. I've added some comments. |
Contributor
Author
|
All fixed. going to work through the doc strings next week hopefully to properly document how each method should be used |
Contributor
Author
|
Oops. broken 22 unit tests. luckily it's at 92% coverage! |
Contributor
Author
|
done and fixed |
Member
There was a problem hiding this comment.
It looks like the limit values are string and not integers? Or just the default values are strings.
In any case, would be better if they were integers.
asfgit
pushed a commit
that referenced
this pull request
Oct 8, 2015
asfgit
pushed a commit
that referenced
this pull request
Oct 8, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended methods for additional functions available in the API.