Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-753 MCP 2 coverage dimension data #593

Conversation

tonybaloney
Copy link
Contributor

Extended methods for additional functions available in the API.

DimensionData Public IP Block with location.
"""

def __init__(self, id, baseIp, size, location, network_domain,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing - for consistency please use base_ip instead of baseIp.

@Kami
Copy link
Member

Kami commented Oct 7, 2015

Great, thanks.

I've added some comments.

@tonybaloney
Copy link
Contributor Author

All fixed. going to work through the doc strings next week hopefully to properly document how each method should be used

@tonybaloney
Copy link
Contributor Author

Oops. broken 22 unit tests. luckily it's at 92% coverage!

@tonybaloney
Copy link
Contributor Author

done and fixed

@@ -355,11 +472,14 @@ def __repr__(self):


class DimensionDataVIPNode(object):
def __init__(self, id, name, status, ip):
def __init__(self, id, name, status, ip, connection_limit='10000',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the limit values are string and not integers? Or just the default values are strings.

In any case, would be better if they were integers.

@asfgit asfgit closed this in 44c4cd6 Oct 8, 2015
asfgit pushed a commit that referenced this pull request Oct 8, 2015
asfgit pushed a commit that referenced this pull request Oct 8, 2015
… update (disable/enable), create and delete. Inc unit tests

Closes #593
asfgit pushed a commit that referenced this pull request Oct 8, 2015
asfgit pushed a commit that referenced this pull request Oct 8, 2015
asfgit pushed a commit that referenced this pull request Oct 8, 2015
asfgit pushed a commit that referenced this pull request Oct 8, 2015
asfgit pushed a commit that referenced this pull request Oct 8, 2015
@Kami
Copy link
Member

Kami commented Oct 8, 2015

Merged, thanks.

return response_code in ['IN_PROGRESS', 'OK']

def ex_delete_firewall_rule(self, rule):
update_node = ET.Element('deleteFirewallrule', {'xmlns': TYPES_URN})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonybaloney I think there is a typo, the XML element name is deleteFirewallRule

@tonybaloney
Copy link
Contributor Author

thanks @EfrenRey the PR is closed but I will fix these issues separately. good catch. these methods are really repetitive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants