New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vultr create_zone zone_id to domain #596

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@aleGpereira
Contributor

aleGpereira commented Oct 9, 2015

A quick fix for vultr

@asfgit asfgit closed this in fe079c9 Oct 10, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 10, 2015

Member

Pushed a fix for failing test (3c6b379) and merged it into trunk.

Thanks.

Member

Kami commented Oct 10, 2015

Pushed a fix for failing test (3c6b379) and merged it into trunk.

Thanks.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 11, 2015

Member

On a related note - I just went over the drivers again and noticed some more issues:

  1. create_zone method signature in Liquidweb DNS driver doesn't conform to the base DNS API
  2. create_zone method signature in DNSimple DNS driver doesn't conform to the base DNS API

@aleGpereira Can you please also address those issues? Thanks!

Member

Kami commented Oct 11, 2015

On a related note - I just went over the drivers again and noticed some more issues:

  1. create_zone method signature in Liquidweb DNS driver doesn't conform to the base DNS API
  2. create_zone method signature in DNSimple DNS driver doesn't conform to the base DNS API

@aleGpereira Can you please also address those issues? Thanks!

@aleGpereira aleGpereira deleted the aleGpereira:change_domain_parameter_vultr branch Oct 12, 2015

@aleGpereira

This comment has been minimized.

Show comment
Hide comment
@aleGpereira

aleGpereira Oct 12, 2015

Contributor

@Kami Done. #601. For some reasons travis took too much time. I couldn't see yet if build was passing. But it should be fine.

Contributor

aleGpereira commented Oct 12, 2015

@Kami Done. #601. For some reasons travis took too much time. I couldn't see yet if build was passing. But it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment