[LIBCLOUD-758] Standardize volumesnapshot state#602
Conversation
|
anyone? @Kami? otherwise I'll merge 😄 |
|
would like this as well |
|
Sorry, didn't have time to review it yet.
|
There was a problem hiding this comment.
In newer parts of the code we decided to replace numeric enum values with string values (e.g. RecordType enum).
Strings makes it easier to see what's going on since you don't need to check the enum type definition to see to which enum name a particular value maps to.
I would appreciate if you can update the code to use string values (e.g. AVAILABLE = 'available', ERROR = ' error', etc.).
In the future I also plan to clean and improve the legacy code and update NodeState to also use string values.
|
Sorry for the delay. I've added one comment - besides that the code looks good to me. I would appreciate if you can address that and when you do, feel free to merge the PR. Thanks! |
allardhoeve
force-pushed
the
standardize-volumesnapshot-state
branch
2 times, most recently
from
8416356 to
81ce457
Compare
|
Changed to strings. Will merge. |
allardhoeve
force-pushed
the
standardize-volumesnapshot-state
branch
2 times, most recently
from
20550df to
533ded5
Compare
LIBCLOUD-759 closes: apache#602 Signed-off-by: Allard Hoeve <allard@byte.nl>
allardhoeve
force-pushed
the
standardize-volumesnapshot-state
branch
from
533ded5 to
728bd88
Compare
There was a problem hiding this comment.
Sorry, for a late comment, I missed this in the previous pass.
For consistency, it would be great if you can change "INUSE" to "IN_USE" and "BACKUP" to "SNAPSHOTING" (this way it's a verb and it's consistent with other states).
Thanks!
There was a problem hiding this comment.
There was a problem hiding this comment.
True, but I personally find "backup" state a bit confusing (backuping is also better, imo, but snapshotting is more provider agnostic) :)
4 participants
No description provided.