Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSIMPLE: Priority typo fix #604

Closed
wants to merge 1 commit into from

Conversation

phumpal
Copy link
Contributor

@phumpal phumpal commented Oct 15, 2015

'prio' is specific to the dnsimple api however libcloud expects 'priority'

@asfgit asfgit closed this in 76c5718 Oct 15, 2015
@Kami
Copy link
Member

Kami commented Oct 15, 2015

Merged, thanks!

@Kami
Copy link
Member

Kami commented Oct 15, 2015

/cc @aleGpereira

@aleGpereira
Copy link
Contributor

@Kami @phumpal isn't the extra dictionary suppose to be driver specific?

@Kami
Copy link
Member

Kami commented Oct 15, 2015

@aleGpereira Correct, although (sadly), right now some "standard" values in the DNS drivers are passed via the extra dictionary - notably "priority" for MX records and ttl.

I hope to eventually refactor / fix that by moving it from the extra dictionary to the method argument.

@phumpal
Copy link
Contributor Author

phumpal commented Oct 15, 2015

👍 thanks @Kami ! I look forward to the refactor / fix 😄

@aleGpereira
Copy link
Contributor

@Kami @phumpal Alright. What matters is that it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants