DNSIMPLE: Priority typo fix#604
Closed
phumpal wants to merge 1 commit into
Closed
Conversation
phumpal
force-pushed
the
fix/dnsimple-priority-patch
branch
from
d91e5f8 to
d55559f
Compare
Member
|
Merged, thanks! |
Member
|
/cc @aleGpereira |
Contributor
Member
|
@aleGpereira Correct, although (sadly), right now some "standard" values in the DNS drivers are passed via the extra dictionary - notably "priority" for MX records and ttl. I hope to eventually refactor / fix that by moving it from the extra dictionary to the method argument. |
Contributor
Author
|
👍 thanks @Kami ! I look forward to the refactor / fix 😄 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'prio'is specific to the dnsimple api however libcloud expects'priority'