Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-760 malformed xml requests #610

Conversation

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Oct 19, 2015

Fixed 2 bugs raised by @EfrenRey where delete Nat rule, edit firewall rule are not containing the right capitalization of Rule in the XML request.

@Kami
Copy link
Member

@Kami Kami commented Oct 20, 2015

/cc @erjohnso

I assume you will merge this when rolling out a new 0.19.0 release, right?

@erjohnso
Copy link
Member

@erjohnso erjohnso commented Oct 20, 2015

Yes. From the thread on dev, we'll close that vote thread and @tonybaloney is planning on adding some basic tests. That can go in this PR too.

…t XML tag of the requests matches the correct documented tag names (and caps)
@tonybaloney
Copy link
Contributor Author

@tonybaloney tonybaloney commented Oct 20, 2015

@erjohnso these are the required tests to check the request bodies as well for typos. all done

@erjohnso
Copy link
Member

@erjohnso erjohnso commented Oct 20, 2015

Outstanding, thank you @tonybaloney!

I'll get this merged in later tonight and start working on the revised 0.19.0 release.

@asfgit asfgit closed this in 4fadb56 Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants