LIBCLOUD-760 malformed xml requests #610

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
4 participants
@tonybaloney
Contributor

tonybaloney commented Oct 19, 2015

Fixed 2 bugs raised by @EfrenRey where delete Nat rule, edit firewall rule are not containing the right capitalization of Rule in the XML request.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 20, 2015

Member

/cc @erjohnso

I assume you will merge this when rolling out a new 0.19.0 release, right?

Member

Kami commented Oct 20, 2015

/cc @erjohnso

I assume you will merge this when rolling out a new 0.19.0 release, right?

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Oct 20, 2015

Member

Yes. From the thread on dev, we'll close that vote thread and @tonybaloney is planning on adding some basic tests. That can go in this PR too.

Member

erjohnso commented Oct 20, 2015

Yes. From the thread on dev, we'll close that vote thread and @tonybaloney is planning on adding some basic tests. That can go in this PR too.

LIBCLOUD-760 Added checks inside the test methods to validate the roo…
…t XML tag of the requests matches the correct documented tag names (and caps)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 20, 2015

Contributor

@erjohnso these are the required tests to check the request bodies as well for typos. all done

Contributor

tonybaloney commented Oct 20, 2015

@erjohnso these are the required tests to check the request bodies as well for typos. all done

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Oct 20, 2015

Member

Outstanding, thank you @tonybaloney!

I'll get this merged in later tonight and start working on the revised 0.19.0 release.

Member

erjohnso commented Oct 20, 2015

Outstanding, thank you @tonybaloney!

I'll get this merged in later tonight and start working on the revised 0.19.0 release.

@asfgit asfgit closed this in 4fadb56 Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment