New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auroracompute: Add support for multiple regions #623

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
4 participants
@wido
Contributor

wido commented Nov 2, 2015

No description provided.

@sebgoa

This comment has been minimized.

Show comment
Hide comment
@sebgoa

sebgoa Nov 3, 2015

Member

Might want to add some tests for this one. Trying to instantiate a driver in the different regions.
Also I am struggling to understand how the endpoint in the different regions gets selected. Your mapping only shows the paths.

Member

sebgoa commented Nov 3, 2015

Might want to add some tests for this one. Trying to instantiate a driver in the different regions.
Also I am struggling to understand how the endpoint in the different regions gets selected. Your mapping only shows the paths.

@wido

This comment has been minimized.

Show comment
Hide comment
@wido

wido Nov 3, 2015

Contributor

@runseb Indeed, tests are a fair point, I'll do that.

We are not using the CloudStack regions as each region runs it's owner manager with accounts. This is due to legal obligations where we don't want to store information in different "legal zones".

api.auroracompute.eu is a HTTP proxy which proxies requests towards the actual CloudStack Management server.

Contributor

wido commented Nov 3, 2015

@runseb Indeed, tests are a fair point, I'll do that.

We are not using the CloudStack regions as each region runs it's owner manager with accounts. This is due to legal obligations where we don't want to store information in different "legal zones".

api.auroracompute.eu is a HTTP proxy which proxies requests towards the actual CloudStack Management server.

@sebgoa

This comment has been minimized.

Show comment
Hide comment
@sebgoa

sebgoa Nov 4, 2015

Member

Ok so the paths proxies to the correct endpoint.
When you add a few tests I will merge it.

Member

sebgoa commented Nov 4, 2015

Ok so the paths proxies to the correct endpoint.
When you add a few tests I will merge it.

@wido

This comment has been minimized.

Show comment
Hide comment
@wido

wido Nov 4, 2015

Contributor

@runseb I just pushed with tests to verify the endpoints. My code seems to work :)

Contributor

wido commented Nov 4, 2015

@runseb I just pushed with tests to verify the endpoints. My code seems to work :)

@asfgit asfgit closed this in 4ba3f8d Nov 5, 2015

@sebgoa

This comment has been minimized.

Show comment
Hide comment
@sebgoa

sebgoa Nov 5, 2015

Member

looks good, merging

Member

sebgoa commented Nov 5, 2015

looks good, merging

'AuroraComputeNodeDriver'
]
class AuroraComputeRegion(object):
AMS = 'Amsterdam'

This comment has been minimized.

@Kami

Kami Nov 5, 2015

Member

Minor thing - for consistency with other drivers it might be better to just use short region names (ams, rtd, mia, etc.)

That's what other drivers which support multiple regions do right now :)

@Kami

Kami Nov 5, 2015

Member

Minor thing - for consistency with other drivers it might be better to just use short region names (ams, rtd, mia, etc.)

That's what other drivers which support multiple regions do right now :)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 4, 2017

Coverage Status

Changes Unknown when pulling f7ac00f on wido:auroracompute-regions into ** on apache:trunk**.

coveralls commented Sep 4, 2017

Coverage Status

Changes Unknown when pulling f7ac00f on wido:auroracompute-regions into ** on apache:trunk**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment