Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auroracompute: Add support for multiple regions #623

Closed
wants to merge 1 commit into from

Conversation

wido
Copy link
Contributor

@wido wido commented Nov 2, 2015

No description provided.

@wido wido force-pushed the auroracompute-regions branch 3 times, most recently from 2ddd6aa to 8d9a06d Compare November 2, 2015 14:11
@sebgoa
Copy link
Member

sebgoa commented Nov 3, 2015

Might want to add some tests for this one. Trying to instantiate a driver in the different regions.
Also I am struggling to understand how the endpoint in the different regions gets selected. Your mapping only shows the paths.

@wido
Copy link
Contributor Author

wido commented Nov 3, 2015

@Runseb Indeed, tests are a fair point, I'll do that.

We are not using the CloudStack regions as each region runs it's owner manager with accounts. This is due to legal obligations where we don't want to store information in different "legal zones".

api.auroracompute.eu is a HTTP proxy which proxies requests towards the actual CloudStack Management server.

@sebgoa
Copy link
Member

sebgoa commented Nov 4, 2015

Ok so the paths proxies to the correct endpoint.
When you add a few tests I will merge it.

@wido
Copy link
Contributor Author

wido commented Nov 4, 2015

@Runseb I just pushed with tests to verify the endpoints. My code seems to work :)

@asfgit asfgit closed this in 4ba3f8d Nov 5, 2015
@sebgoa
Copy link
Member

sebgoa commented Nov 5, 2015

looks good, merging

'AuroraComputeNodeDriver'
]


class AuroraComputeRegion(object):
AMS = 'Amsterdam'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing - for consistency with other drivers it might be better to just use short region names (ams, rtd, mia, etc.)

That's what other drivers which support multiple regions do right now :)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f7ac00f on wido:auroracompute-regions into ** on apache:trunk**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants