-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auroracompute: Add support for multiple regions #623
Conversation
2ddd6aa
to
8d9a06d
Compare
Might want to add some tests for this one. Trying to instantiate a driver in the different regions. |
@Runseb Indeed, tests are a fair point, I'll do that. We are not using the CloudStack regions as each region runs it's owner manager with accounts. This is due to legal obligations where we don't want to store information in different "legal zones". api.auroracompute.eu is a HTTP proxy which proxies requests towards the actual CloudStack Management server. |
Ok so the paths proxies to the correct endpoint. |
8d9a06d
to
6957cc8
Compare
6957cc8
to
f7ac00f
Compare
@Runseb I just pushed with tests to verify the endpoints. My code seems to work :) |
looks good, merging |
'AuroraComputeNodeDriver' | ||
] | ||
|
||
|
||
class AuroraComputeRegion(object): | ||
AMS = 'Amsterdam' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing - for consistency with other drivers it might be better to just use short region names (ams, rtd, mia, etc.)
That's what other drivers which support multiple regions do right now :)
Changes Unknown when pulling f7ac00f on wido:auroracompute-regions into ** on apache:trunk**. |
No description provided.