Skip to content

auroracompute: Add support for multiple regions - #623

Closed
wido wants to merge 1 commit into
apache:trunkfrom
wido:auroracompute-regions
Closed

auroracompute: Add support for multiple regions#623
wido wants to merge 1 commit into
apache:trunkfrom
wido:auroracompute-regions

Conversation

@wido

@wido wido commented Nov 2, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@wido
wido force-pushed the auroracompute-regions branch 3 times, most recently from 2ddd6aa to 8d9a06d Compare November 2, 2015 14:11
@sebgoa

sebgoa commented Nov 3, 2015

Copy link
Copy Markdown
Member

Might want to add some tests for this one. Trying to instantiate a driver in the different regions.
Also I am struggling to understand how the endpoint in the different regions gets selected. Your mapping only shows the paths.

@wido

wido commented Nov 3, 2015

Copy link
Copy Markdown
Contributor Author

@Runseb Indeed, tests are a fair point, I'll do that.

We are not using the CloudStack regions as each region runs it's owner manager with accounts. This is due to legal obligations where we don't want to store information in different "legal zones".

api.auroracompute.eu is a HTTP proxy which proxies requests towards the actual CloudStack Management server.

@sebgoa

sebgoa commented Nov 4, 2015

Copy link
Copy Markdown
Member

Ok so the paths proxies to the correct endpoint.
When you add a few tests I will merge it.

@wido
wido force-pushed the auroracompute-regions branch from 8d9a06d to 6957cc8 Compare November 4, 2015 09:52
@wido
wido force-pushed the auroracompute-regions branch from 6957cc8 to f7ac00f Compare November 4, 2015 09:57
@wido

wido commented Nov 4, 2015

Copy link
Copy Markdown
Contributor Author

@Runseb I just pushed with tests to verify the endpoints. My code seems to work :)

@asfgit asfgit closed this in 4ba3f8d Nov 5, 2015
@sebgoa

sebgoa commented Nov 5, 2015

Copy link
Copy Markdown
Member

looks good, merging

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing - for consistency with other drivers it might be better to just use short region names (ams, rtd, mia, etc.)

That's what other drivers which support multiple regions do right now :)

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling f7ac00f on wido:auroracompute-regions into ** on apache:trunk**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants