Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-767] Fixed CloudStackAddress parameters #627

Closed
wants to merge 1 commit into from

Conversation

atsaki
Copy link
Contributor

@atsaki atsaki commented Nov 7, 2015

This fixes the parameters of CloudStackAddress of node.extra['ip_addresses'].

https://issues.apache.org/jira/browse/LIBCLOUD-767

@Kami
Copy link
Member

Kami commented Nov 7, 2015

Thanks.

LGTM

@asfgit asfgit closed this in b37548b Nov 8, 2015
@Kami
Copy link
Member

Kami commented Nov 8, 2015

Made a small change to use kwargs to make it more explicit (59ce903) and merged patch into trunk. Thanks!

On a related note - looks like a similar bug exists here -

addresses = [CloudStackAddress(node, v, k) for k, v in addresses]
, but I wasn't able to confirm it since we don't have any test fixtures which exercise that code path (ips is always an empty list) and I don't have easy access to CloudStack installation right now.

Can you please have a look?

@atsaki
Copy link
Contributor Author

atsaki commented Nov 10, 2015

Thanks @Kami .

On a related note - looks like a similar bug exists here -

addresses = [CloudStackAddress(node, v, k) for k, v in addresses]
, but I wasn't able to confirm it since we don't have any test fixtures which exercise that code path (ips is always an empty list) and I don't have easy access to CloudStack installation right now.

This will be addressed in #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants