LIBCLOUD 770 wait for state

[tonybaloney]

Support for waiting for a request to reach a target state (i.e. provisioned)

[Kami]

It might be a good idea to make the sleep interval configurable with a function argument.

[Kami]

if we make this a bit more generic and safe (timeout, etc.) we could also consider it adding to the base NodeDriver class.

[tonybaloney]

Updated code to reflect comments. Agree on adding it to nodedriver, I've seen similar helper methods in libraries consuming libcloud, would need to research whether all of the drivers use the same field name (status).

[tonybaloney]

all done

[Kami]

I have trouble applying the patch directly onto trunk.

Can you please sync this branch with latest trunk and squash the commits?

[tonybaloney]

NTTLimitedRD@609fa85
squashed. I resynced but there weren't any differences with trunk. see if this is mergable

[Kami]

I'm still having issues, I will manually apply it tomorrow by directly merging your branch locally :)

kami ~/w/lc/libcloud (git:trunk)$ git am --signoff 609fa8541188fb3daae7653e253c77c0dd422c2f.patch
Applying: Provide a way for users to wait for an asset to complete (+4 squashed commit)
error: patch failed: libcloud/common/dimensiondata.py:218
error: libcloud/common/dimensiondata.py: patch does not apply
error: patch failed: libcloud/compute/drivers/dimensiondata.py:815
error: libcloud/compute/drivers/dimensiondata.py: patch does not apply
error: patch failed: libcloud/loadbalancer/drivers/dimensiondata.py:823
error: libcloud/loadbalancer/drivers/dimensiondata.py: patch does not apply
Patch failed at 0001 Provide a way for users to wait for an asset to complete (+4 squashed commit)
The copy of the patch that failed is found in:
   /home/kami/w/lc/libcloud/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

[Kami]

Alright, I merged the changes. Thanks.

Here is what I did:

git fetch dd
git checkout LIBCLOUD-770_Wait_for_state
git rebase trunk  -> that's the important part since it replayed your changes on top of trunk so the changes were now in the mergable order
git format-patch trunk --stdout > 1.patch
git checkout trunk
git am --signoff 1.patch

I also made a small change - I supplied default value for poll_interval and timeout argument and changed exception message to also include response body - 4a74243. Let me know if the response.body change looks OK.

[tonybaloney]

would response.body have any value?

here's an example of me using it>

so ex_get_vlan returns a DimensionDataVlan object instance, which doensn't
have a body attribute.

driver.ex_wait_for_state('NORMAL', driver.ex_get_vlan, result['id'])

On Fri, Nov 13, 2015 at 10:06 AM, Tomaz Muraus notifications@github.com
wrote:

Alright, I merged the changes. Thanks.

Here is what I did:

git fetch dd
git checkout LIBCLOUD-770_Wait_for_state
git rebase trunk
git format-patch trunk --stdout > 1.patch
git checkout trunk
git am --signoff 1.patch

I also made a small change - I supplied default value for poll_interval
and timeout argument and changed exception message to also include response
body - 4a74243
4a74243.
Let me know if the response.body change looks OK.

—
Reply to this email directly or view it on GitHub
#631 (comment).

[Kami]

@tonybaloney Ah, you are correct.

I was confused for a second since the method is on a connection class, but it actually returns an object not the raw response from the connection class (it returns result from a calling method).

I will revert that change and change variable name from response to result to make it a bit less confusing (response in connection class usually refers to an instance of Libcloud HTTP response class).

[Kami]

Alright, I've pushed a fix in - 232f949.

Another minor feature improvement would be to change the method signature to (state, poll_interval, timeout, func, *args, **kargs). This way you can partially apply the function, e.g.:

wait_for_vlan = functools.partial(self.wait_for_state, state=foo, func=self.ex_get_vlan)
vlan = wait_for_vlan(...)

Or you could even modify the method to return an already partially applied function which user can use directly.

[tonybaloney]

my python knowledge doesn't extend that far. I was only just up to
functools.wrap
maybe soon I'll know what you're talking about!

On Fri, Nov 13, 2015 at 10:35 AM, Tomaz Muraus notifications@github.com
wrote:

Alright, I've pushed a fix in - 232f949
232f949
.

Another minor feature improvement would be to change the method signature
to (state, poll_interval, timeout, func, _args, *_kargs). This way you
can partially apply the function, e.g.:

wait_for_vlan = functools.partial(self.wait_for_state, state=foo, func=self.ex_get_vlan)
result = wait_for_vlan(...)

Or you could even modify the method to return an already partially applied
function which user can use directly.

—
Reply to this email directly or view it on GitHub
#631 (comment).

[coveralls]

Changes Unknown when pulling 55f24e3 on DimensionDataCBUSydney:LIBCLOUD-770_Wait_for_state into ** on apache:trunk**.

[pquentin]

If possible, it would be nice to disable coveralls who keeps posting random comments in old pull requests.