Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFlare DNS driver #637

Merged
merged 14 commits into from Dec 6, 2015
Merged

CloudFlare DNS driver #637

merged 14 commits into from Dec 6, 2015

Conversation

@Kami
Copy link
Member

Kami commented Nov 21, 2015

New driver for CloudFlare DNS (WIP).

TODO:

  • Support for record management (create, edit, delete)
  • Tests
  • Pagination support
@Kami Kami changed the title [WIP] CloudFlare DNS driver CloudFlare DNS driver Dec 6, 2015
@Kami Kami force-pushed the Kami:cloudflare_dns_driver branch from 3d61af4 to 66ff9d4 Dec 6, 2015
@Kami Kami closed this Dec 6, 2015
@Kami Kami reopened this Dec 6, 2015
@Kami
Copy link
Member Author

Kami commented Dec 6, 2015

Alright, added the tests and fixed some things.

I will go ahead and merge it and implement pagination in a future PR (driver is already functional without pagination as long as you have < page size number of zones and records).

@asfgit asfgit merged commit c7ffbe7 into apache:trunk Dec 6, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -0,0 +1,10 @@
{

This comment has been minimized.

@tonybaloney

tonybaloney Dec 22, 2015 Contributor

@Kami nul is a reserved file name in Windows, so anyone trying to test or use this on Windows is going to have a lot a bad time.. Please can you rename it

This comment has been minimized.

@Kami

Kami Dec 23, 2015 Author Member

Even if it has an extension (aka nul.json)?

This comment has been minimized.

@Kami

Kami Dec 23, 2015 Author Member

It looks like it, that's unfortunate :P

Good catch - will rename it.

This comment has been minimized.

@Kami

Kami Dec 23, 2015 Author Member

Would make it easier if we could also automatically run tests on Windows, but Travis sadly doesn't support that (yet).

@dol
Copy link

dol commented Jul 28, 2016

@Kami Thank you for the driver. Any reason the driver uses a old version of the Cloudflare API -> https://www.cloudflare.com/docs/client-api.html .
CloudFlare is removing support for this API on November 9th, 2016.

@Kami
Copy link
Member Author

Kami commented Jul 28, 2016

@dol I think that when I added it, new version of the API wasn't there yet (or I missed it).

@dol
Copy link

dol commented Jul 28, 2016

Ok. Sorry, the question was unfortunate.
Any plans switching over to the new API version?

@Kami
Copy link
Member Author

Kami commented Jul 28, 2016

I don't have any plans, but contributions are welcome (you can also ping / ask CloudFlare people).

@dol
Copy link

dol commented Jul 28, 2016

I'm not that frequent in Python. Might be better to call your friends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.