-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudFlare DNS driver #637
Conversation
3d61af4
to
66ff9d4
Compare
Conflicts: libcloud/dns/types.py libcloud/test/secrets.py-dist
Alright, added the tests and fixed some things. I will go ahead and merge it and implement pagination in a future PR (driver is already functional without pagination as long as you have < page size number of zones and records). |
@@ -0,0 +1,10 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kami nul is a reserved file name in Windows, so anyone trying to test or use this on Windows is going to have a lot a bad time.. Please can you rename it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it has an extension (aka nul.json
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it, that's unfortunate :P
Good catch - will rename it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make it easier if we could also automatically run tests on Windows, but Travis sadly doesn't support that (yet).
@Kami Thank you for the driver. Any reason the driver uses a old version of the Cloudflare API -> https://www.cloudflare.com/docs/client-api.html . |
@dol I think that when I added it, new version of the API wasn't there yet (or I missed it). |
Ok. Sorry, the question was unfortunate. |
I don't have any plans, but contributions are welcome (you can also ping / ask CloudFlare people). |
I'm not that frequent in Python. Might be better to call your friends. |
New driver for CloudFlare DNS (WIP).
TODO: