EC2 updates #646
Closed
EC2 updates #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values on <https://aws.amazon.com/ec2/instance-types/?nc1=f_ls> are given in [GiB]. Let Python convert them to [MiB], as the current values are a mix of [MB] and [MiB].
The values on <https://aws.amazon.com/ec2/instance-types/?nc1=f_ls> are given in [GB]. Let Python calculate the size of multiple disks. Remove wrong factor 1000 from m3 instances.
Add vCPU information from <https://aws.amazon.com/ec2/instance-types/?nc1=f_ls>
|
@pmhahn thanks for the submission, the tests are failing because pricing.json is missing the new instance types, e.g. |
i2 are I/O optimized, while d2 are dense optimized
t2.micro is also a "Burstable Performance General Purpose" instance type.
Add source URLs. Add unit type for RAM and disk size.
Commit b7d851f added the pricing info twice.
contrib/scrape-ec2-prices.py changes the ordering of data/pricing.json, as it sorts the dictionary keys by string, which puts '10' before '2'. Add a function to split the dictionary keys into the numeric, alphabetic and other part and compare the first as integer, the middle by meaning, and the later as string.
Please note that the scraper stores the price as string and does not beautify the string to have exactly 3 digits in the radix part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EC2 Instance Type information contains some errors (especially the disk size for the m3 instances), conversion errors between GiB an M[i]B, disk count, ..
Also g2.8xlarge and t2.large are missing.