New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 updates #646

Closed
wants to merge 10 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@pmhahn

pmhahn commented Dec 1, 2015

The EC2 Instance Type information contains some errors (especially the disk size for the m3 instances), conversion errors between GiB an M[i]B, disk count, ..
Also g2.8xlarge and t2.large are missing.

pmhahn added some commits Dec 1, 2015

EC2: Specify RAM size in GiB
The values on <https://aws.amazon.com/ec2/instance-types/?nc1=f_ls> are
given in [GiB].

Let Python convert them to [MiB], as the current values are a mix of
[MB] and [MiB].
EC2: Fix disk size
The values on <https://aws.amazon.com/ec2/instance-types/?nc1=f_ls> are
given in [GB].

Let Python calculate the size of multiple disks.

Remove wrong factor 1000 from m3 instances.
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Dec 2, 2015

Contributor

@pmhahn thanks for the submission, the tests are failing because pricing.json is missing the new instance types, e.g.
KeyError: 'g2.8xlarge'
Please can you add the missing prices and resubmit

Contributor

tonybaloney commented Dec 2, 2015

@pmhahn thanks for the submission, the tests are failing because pricing.json is missing the new instance types, e.g.
KeyError: 'g2.8xlarge'
Please can you add the missing prices and resubmit

pmhahn added some commits Dec 1, 2015

EC2: Rename i2 and d2 instance types
i2 are I/O optimized, while d2 are dense optimized
EC2: Move comment before t2 instances
t2.micro is also a "Burstable Performance General Purpose" instance
type.
EC2: Add clarifications
Add source URLs.
Add unit type for RAM and disk size.
EC2: Update pricing
Please note that the scraper stores the price as string and does not
beautify the string to have exactly 3 digits in the radix part.
Remove duplicate pricing info
Commit b7d851f added the pricing info twice.
EC2: Sort pricing by (non-)numeric part
contrib/scrape-ec2-prices.py changes the ordering of data/pricing.json,
as it sorts the dictionary keys by string, which puts '10' before '2'.

Add a function to split the dictionary keys into the numeric, alphabetic
and other part and compare the first as integer, the middle by meaning,
and the later as string.

@pmhahn pmhahn closed this Dec 2, 2015

asfgit pushed a commit that referenced this pull request Dec 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment