New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'service_name' support in _parse_service_catalog_auth_v3 for Openstack Drivers #647

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
4 participants
@steve-gregory
Contributor

steve-gregory commented Dec 1, 2015

The 'service_name' attribute was being left out when parsing the v3 ServiceCatalog returned by OpenStack. As a result, this error would occur: LibcloudError: <LibcloudError in None 'Could not find specified endpoint'>

The solution is to parse and add the service_name to the OpenStackServiceCatalogEntry similar to how it was done in _parse_service_catalog_auth_v2.

@jimbobhickville

This comment has been minimized.

Show comment
Hide comment
@jimbobhickville

jimbobhickville Dec 2, 2015

Contributor

+1 makes sense to me

Contributor

jimbobhickville commented Dec 2, 2015

+1 makes sense to me

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Dec 2, 2015

Contributor

Thanks @steve-gregory will merge

Contributor

tonybaloney commented Dec 2, 2015

Thanks @steve-gregory will merge

@asfgit asfgit closed this in 990ecf7 Dec 2, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 3, 2015

Member

Thanks.

It's been a while since I wrote this, but IIRC, name was not available in the service catalog when I was originally testing this. It's possible that things have changed since then, but some tests would also be good :)

Member

Kami commented Dec 3, 2015

Thanks.

It's been a while since I wrote this, but IIRC, name was not available in the service catalog when I was originally testing this. It's possible that things have changed since then, but some tests would also be good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment