Include 'service_name' support in _parse_service_catalog_auth_v3 for Openstack Drivers#647
Closed
steve-gregory wants to merge 1 commit into
Closed
Include 'service_name' support in _parse_service_catalog_auth_v3 for Openstack Drivers#647steve-gregory wants to merge 1 commit into
steve-gregory wants to merge 1 commit into
Conversation
|
+1 makes sense to me |
Contributor
|
Thanks @steve-gregory will merge |
Member
|
Thanks. It's been a while since I wrote this, but IIRC, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'service_name' attribute was being left out when parsing the v3 ServiceCatalog returned by OpenStack. As a result, this error would occur:
LibcloudError: <LibcloudError in None 'Could not find specified endpoint'>The solution is to parse and add the service_name to the
OpenStackServiceCatalogEntrysimilar to how it was done in_parse_service_catalog_auth_v2.