-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for vCloud 5.5 and snapshot operations #658
Conversation
Hi @juanfont this would be a great feature to have but the tests are failing. please check and recommit.. FAIL: test_list_nodes (libcloud.test.compute.test_vcloud.VCloud_1_5_Tests)Traceback (most recent call last): |
@tonybaloney Can you check now? Thank you very much :) |
Hi @juanfont do you have an API instance you can test this against? Ideally, there should be supporting tests and fixtures for this. See the test methods for the 5.1 API as an example: libcloud/libcloud/test/compute/test_vcloud.py Lines 337 to 394 in c948728
|
@tonybaloney yes, this has been tested against a real vCloud Director instance. But you are right, I'll provide tests ASAP. |
Hi @juanfont how did you get on with the tests? Would be good to get this closed off since you've already done most of the hard work! |
@tonybaloney sorry about the delay. Hope it is enough :) |
Great! thanks @juanfont 👍 |
The vCloud 5.5 commit cames from Philip Kershaw (philip.kershaw@stfc.ac.uk), although it seems he never sent it to upstream. He talks about it here http://mail-archives.apache.org/mod_mbox/libcloud-dev/201403.mbox/%3C836226893590734FA88B31162359477F5F7FFE90@EXCHMBX01.fed.cclrc.ac.uk%3E.
The second commit adds snapshot management (create, delete, restore) methods. It also adds 'snapshots' as new field in the 'extra' dict.