New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auroradns: Further improve unit tests #679

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@wido
Contributor

wido commented Jan 11, 2016

No description provided.

@wido

This comment has been minimized.

Show comment
Hide comment
@wido

wido Jan 11, 2016

Contributor

This contains the fix from my previous pr @runseb

It is also covered by a UnitTest

Contributor

wido commented Jan 11, 2016

This contains the fix from my previous pr @runseb

It is also covered by a UnitTest

@wido wido closed this Jan 11, 2016

@wido wido reopened this Jan 11, 2016

@wido

This comment has been minimized.

Show comment
Hide comment
@wido

wido Jan 13, 2016

Contributor

The tests all pass, can we merge this one? It only adds unit tests

Contributor

wido commented Jan 13, 2016

The tests all pass, can we merge this one? It only adds unit tests

def test_get_zone(self):
zone = self.driver.get_zone('example.com')
self.assertEquals(zone.domain, 'example.com')
self.assertEquals(zone.id, 'ffb62570-8414-4578-a346-526b44e320b7')

This comment has been minimized.

@sebgoa

sebgoa Jan 13, 2016

Member

I am going to merge it, but assertEquals is deprecated so its gives several warnings to use assertEqual instead.
I will let you fix that in the subsequent PR

@sebgoa

sebgoa Jan 13, 2016

Member

I am going to merge it, but assertEquals is deprecated so its gives several warnings to use assertEqual instead.
I will let you fix that in the subsequent PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment