Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upauroradns: Further improve unit tests #679
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
wido
Jan 11, 2016
Contributor
This contains the fix from my previous pr @runseb
It is also covered by a UnitTest
|
This contains the fix from my previous pr @runseb It is also covered by a UnitTest |
wido
closed this
Jan 11, 2016
wido
reopened this
Jan 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
The tests all pass, can we merge this one? It only adds unit tests |
sebgoa
reviewed
Jan 13, 2016
| def test_get_zone(self): | ||
| zone = self.driver.get_zone('example.com') | ||
| self.assertEquals(zone.domain, 'example.com') | ||
| self.assertEquals(zone.id, 'ffb62570-8414-4578-a346-526b44e320b7') |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
sebgoa
Jan 13, 2016
Member
I am going to merge it, but assertEquals is deprecated so its gives several warnings to use assertEqual instead.
I will let you fix that in the subsequent PR
sebgoa
Jan 13, 2016
Member
I am going to merge it, but assertEquals is deprecated so its gives several warnings to use assertEqual instead.
I will let you fix that in the subsequent PR
asfgit
closed this
in
c37f15f
Jan 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wido commentedJan 11, 2016
No description provided.