Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upauroradns: Further improve unit tests #679
Closed
Conversation
|
This contains the fix from my previous pr @Runseb It is also covered by a UnitTest |
wido
force-pushed the
wido:auroradns-test
branch
2 times, most recently
from
cc0d40b
to
7d44656
|
The tests all pass, can we merge this one? It only adds unit tests |
| def test_get_zone(self): | ||
| zone = self.driver.get_zone('example.com') | ||
| self.assertEquals(zone.domain, 'example.com') | ||
| self.assertEquals(zone.id, 'ffb62570-8414-4578-a346-526b44e320b7') |
This comment has been minimized.
This comment has been minimized.
sebgoa
Jan 13, 2016
Member
I am going to merge it, but assertEquals is deprecated so its gives several warnings to use assertEqual instead.
I will let you fix that in the subsequent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wido commentedJan 11, 2016
No description provided.