Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auroradns: Further improve unit tests #679

Closed
wants to merge 1 commit into from

Conversation

wido
Copy link
Contributor

@wido wido commented Jan 11, 2016

No description provided.

@wido
Copy link
Contributor Author

wido commented Jan 11, 2016

This contains the fix from my previous pr @Runseb

It is also covered by a UnitTest

@wido wido closed this Jan 11, 2016
@wido wido reopened this Jan 11, 2016
@wido wido force-pushed the auroradns-test branch 2 times, most recently from cc0d40b to 7d44656 Compare January 13, 2016 12:51
@wido
Copy link
Contributor Author

wido commented Jan 13, 2016

The tests all pass, can we merge this one? It only adds unit tests

def test_get_zone(self):
zone = self.driver.get_zone('example.com')
self.assertEquals(zone.domain, 'example.com')
self.assertEquals(zone.id, 'ffb62570-8414-4578-a346-526b44e320b7')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge it, but assertEquals is deprecated so its gives several warnings to use assertEqual instead.
I will let you fix that in the subsequent PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants