Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 support for AWS Seoul region #684

Closed
wants to merge 3 commits into from
Closed

Conversation

@encyphered
Copy link
Contributor

encyphered commented Jan 26, 2016

  • Fixed signature version of AWS Seoul region to 4 due to that does not support
  • Added provider and driver for region.
@tonybaloney
Copy link
Contributor

tonybaloney commented Jan 26, 2016

Thanks @encyphered do you have instances deployed in Seoul? Amazons press release said a subset of instance sizes for EC2 was supported, is this correct?

@encyphered
Copy link
Contributor Author

encyphered commented Jan 26, 2016

@tonybaloney Yes, Amazon announced only T2, M4, C4, I2, D2, and R3 was supported. HS1 is not supported

@tonybaloney
Copy link
Contributor

tonybaloney commented Jan 27, 2016

thanks. LGTM +1

@asfgit asfgit closed this in b0ce8d8 Jan 27, 2016
@Kami
Copy link
Member

Kami commented Jan 27, 2016

Thanks for the PR.

Does the new region only support new signature version 4? I'm asking because right now, IIRC, we only support signature version 4 for HTTP GET methods in Libcloud which means we should use 2 if it's still supported (otherwise non GET operations won't work).

@tonybaloney
Copy link
Contributor

tonybaloney commented Jan 27, 2016

I added POST request support for v4 about a month ago 

Sent from Outlook Mobile

On Wed, Jan 27, 2016 at 1:55 AM -0800, "Tomaz Muraus" notifications@github.com wrote:

Thanks for the PR.

Does the new region only support new signature version 4? I'm asking because right now, IIRC, we only support signature version 4 for HTTP GET methods in Libcloud which means we should use 2 if it's still supported (otherwise non GET operations won't work).


Reply to this email directly or view it on GitHub.

@Kami
Copy link
Member

Kami commented Jan 27, 2016

@tonybaloney Ah, nice! :)

I totally missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.