Repository navigation
Conversation
GoogleStorageConnection to not inherit from GoogleBaseConnection. Separated OAuth2 credential management from GoogleBaseConnection. This allows both GoogleBaseConnection and GoogleStorageConnection to use OAuth2. Modified and ran tests to validate changes. Also ran a few manual tests.
Contributor
Author
Contributor
Author
|
Merged. |
|
Changes Unknown when pulling 536d027 on crunk1:trunk into ** on apache:trunk**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoogleStorageConnection to not inherit from GoogleBaseConnection. Separated OAuth2 credential management from GoogleBaseConnection. This allows both GoogleBaseConnection and GoogleStorageConnection to use OAuth2. Modified and ran tests to validate changes.
Also ran a few manual tests using GoogleStorageDriver and GCENodeDriver. GoogleStorageDriver works with either OAuth2 credentials or S3 Interoperability credentials. Tested setting the mime type on an uploaded GCS object.