Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing https://issues.apache.org/jira/browse/LIBCLOUD-800. Changed #689

Closed
wants to merge 1 commit into from

Conversation

@crunk1
Copy link
Contributor

@crunk1 crunk1 commented Feb 2, 2016

GoogleStorageConnection to not inherit from GoogleBaseConnection. Separated OAuth2 credential management from GoogleBaseConnection. This allows both GoogleBaseConnection and GoogleStorageConnection to use OAuth2. Modified and ran tests to validate changes.

Also ran a few manual tests using GoogleStorageDriver and GCENodeDriver. GoogleStorageDriver works with either OAuth2 credentials or S3 Interoperability credentials. Tested setting the mime type on an uploaded GCS object.

GoogleStorageConnection to not inherit from GoogleBaseConnection.
Separated OAuth2 credential management from GoogleBaseConnection. This
allows both GoogleBaseConnection and GoogleStorageConnection to use
OAuth2. Modified and ran tests to validate changes.

Also ran a few manual tests.
@crunk1
Copy link
Contributor Author

@crunk1 crunk1 commented Feb 2, 2016

@crunk1
Copy link
Contributor Author

@crunk1 crunk1 commented Feb 9, 2016

Merged.

@crunk1 crunk1 closed this Feb 9, 2016
@coveralls
Copy link

@coveralls coveralls commented Jan 17, 2018

Coverage Status

Changes Unknown when pulling 536d027 on crunk1:trunk into ** on apache:trunk**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.