New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DimensionData: Adding in server filters to list nodes #694

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@jadunham1
Contributor

jadunham1 commented Feb 8, 2016

Adding in the filters available for the list servers API for DimensionData
Adding tests to make sure those filters are working as expected

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
:type state: ``str``
:keyword network: The network filter
:type notwork: :class:`DimensionDataNetwork` or ``str``

This comment has been minimized.

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be :type network

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be :type network

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
:type notwork: :class:`DimensionDataNetwork` or ``str``
:keyword network_domain: The network domain filter
:type notwork_domain: :class:`DimensionDataNetworkDomain` or ``str``

This comment has been minimized.

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be :type network_domain

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be :type network_domain

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
:keyword image: The image filter
:type image: :class:`NodeImage` or ``str``
:keyword deployed: The deployed filter

This comment has been minimized.

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

could you be a bit more descriptive, for users that don't use the MCP API much

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

could you be a bit more descriptive, for users that don't use the MCP API much

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
:type ex_notwork: :class:`DimensionDataNetwork` or ``str``
:keyword ex_network_domain: The network domain filter
:type ex_notwork_domain: :class:`DimensionDataNetworkDomain`

This comment has been minimized.

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be ex_network_domain

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be ex_network_domain

Show outdated Hide outdated libcloud/compute/drivers/dimensiondata.py
:type ex_state: ``str``
:keyword ex_network: The network filter
:type ex_notwork: :class:`DimensionDataNetwork` or ``str``

This comment has been minimized.

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be ex_network

@tonybaloney

tonybaloney Feb 9, 2016

Contributor

should be ex_network

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Feb 9, 2016

Contributor

couple of typos in the docstrings but otherwise 👍

Contributor

tonybaloney commented Feb 9, 2016

couple of typos in the docstrings but otherwise 👍

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Feb 10, 2016

Much better thanks

tonybaloney commented on 7cfaed0 Feb 10, 2016

Much better thanks

@asfgit asfgit closed this in 513bc17 Feb 10, 2016

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Feb 10, 2016

Contributor

Merged 👍

Contributor

tonybaloney commented Feb 10, 2016

Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment