Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DimensionData: Adding in server filters to list nodes #694

Closed
wants to merge 3 commits into from

Conversation

jadunham1
Copy link
Contributor

@jadunham1 jadunham1 commented Feb 8, 2016

Adding in the filters available for the list servers API for DimensionData
Adding tests to make sure those filters are working as expected

:type state: ``str``

:keyword network: The network filter
:type notwork: :class:`DimensionDataNetwork` or ``str``
Copy link
Contributor

@tonybaloney tonybaloney Feb 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be :type network

@tonybaloney
Copy link
Contributor

tonybaloney commented Feb 9, 2016

couple of typos in the docstrings but otherwise 👍

@asfgit asfgit closed this in 513bc17 Feb 10, 2016
@tonybaloney
Copy link
Contributor

tonybaloney commented Feb 10, 2016

Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants