New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DimensionData: Adding in new methods/tests for backups #695

Closed
wants to merge 5 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@jadunham1
Contributor

jadunham1 commented Feb 8, 2016

Added in ability to add clients to a target
Added in ability to list backup info for a target
Added in positive tests

@jadunham1

This comment has been minimized.

Show comment
Hide comment
@jadunham1

jadunham1 Feb 9, 2016

Contributor

I'm unhappy with how the classes for backups objects are directly defined here instead of in the common library. I'm going to make this change as well.

Contributor

jadunham1 commented Feb 9, 2016

I'm unhappy with how the classes for backups objects are directly defined here instead of in the common library. I'm going to make this change as well.

@jadunham1

This comment has been minimized.

Show comment
Hide comment
@jadunham1

jadunham1 Feb 9, 2016

Contributor

Added negative tests around the info call if backups don't exist.
Moved the classes to common where the classes for the node exist.
Added a bunch of docs on the classes themselves.

Contributor

jadunham1 commented Feb 9, 2016

Added negative tests around the info call if backups don't exist.
Moved the classes to common where the classes for the node exist.
Added a bunch of docs on the classes themselves.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Feb 10, 2016

Contributor

the additional changes look great. thanks @jadunham1 merging.

Contributor

tonybaloney commented Feb 10, 2016

the additional changes look great. thanks @jadunham1 merging.

@asfgit asfgit closed this in 2b6024e Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment