Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecated providers with a error message and a URL to follow up #701

Closed
wants to merge 2 commits into from

Conversation

@tonybaloney
Copy link
Contributor Author

tonybaloney commented Feb 12, 2016

@Kami @erjohnso @jcsalterego @Runseb @allardhoeve - this is an important one. Are you happy with the way this works?

@allardhoeve
Copy link
Contributor

allardhoeve commented Feb 12, 2016

Looks simple enough to me.

@erjohnso
Copy link
Member

erjohnso commented Feb 12, 2016

LGTM @tonybaloney. Nice clean up!

@asfgit asfgit closed this in d2ca6cd Feb 12, 2016
asfgit pushed a commit that referenced this pull request Feb 12, 2016
@Kami
Copy link
Member

Kami commented Feb 14, 2016

Yay, removing code is always great (less stuff to maintainer, less surface area for bugs, etc.) :P

LGTM

@@ -190,6 +181,12 @@


def get_driver(provider):
if provider in DEPRECATED_DRIVERS:

This comment has been minimized.

@Kami

Kami Feb 14, 2016 Member

A test case for this would be nice :)

url = DEPRECATED_DRIVERS[provider]['url']
reason = DEPRECATED_DRIVERS[provider]['reason']
msg = ('Provider no longer supported: %s, please visit: %s' %
(url, reason))

This comment has been minimized.

@Kami

Kami Feb 14, 2016 Member

Also, looks like it should be % (reason, url) - reason first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.