Handle deprecated providers with a error message and a URL to follow up#701
Closed
tonybaloney wants to merge 2 commits into
Closed
Handle deprecated providers with a error message and a URL to follow up#701tonybaloney wants to merge 2 commits into
tonybaloney wants to merge 2 commits into
Conversation
Contributor
Author
|
@Kami @erjohnso @jcsalterego @Runseb @allardhoeve - this is an important one. Are you happy with the way this works? |
Contributor
|
Looks simple enough to me. |
Contributor
|
LGTM @tonybaloney. Nice clean up! |
asfgit
pushed a commit
that referenced
this pull request
Feb 12, 2016
Member
|
Yay, removing code is always great (less stuff to maintainer, less surface area for bugs, etc.) :P LGTM |
|
|
||
|
|
||
| def get_driver(provider): | ||
| if provider in DEPRECATED_DRIVERS: |
Member
There was a problem hiding this comment.
A test case for this would be nice :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See - http://libcloud.apache.org/blog/2016/02/16/new-drivers-deprecated-drivers.html